Re: pkg/54878: lang/spidermonkey52 configuration fails in chroot

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

The following reply was made to PR pkg/54878; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <triaxx%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: tech-pkg%NetBSD.org@localhost
Subject: Re: pkg/54878: lang/spidermonkey52 configuration fails in chroot
Date: Mon, 02 Mar 2020 16:00:51 +0100

 The patch below fix the bug but I am not sure to have clearly identified 
 the problem. It occurs only when I build lang/spidermonkey52 with 
 pbulk+sandbox. I noticed that in this context I got:
 activate_mtime=X
 dep_mtime=X+1 (approximately)
 whereas I got the following when I 'make configure' in my pkgsrc tree 
 (out of pbulk, sandbox and chroot):
 activate_mtime=X
 dep_mtime=X-5 (approximately)
 
 I tried MAKE_JOBS_SAFE=no but without any success.
 
 Does anyone see an objection to commit this patch?
 
 cvs diff: Diffing .
 Index: distinfo
 ===================================================================
 RCS file: /cvsroot/pkgsrc/lang/spidermonkey52/distinfo,v
 retrieving revision 1.8
 diff -u -r1.8 distinfo
 --- distinfo    8 Oct 2019 21:34:15 -0000       1.8
 +++ distinfo    2 Mar 2020 14:17:39 -0000
 @@ -22,3 +22,4 @@
   SHA1 (patch-mozglue_build_moz.build) = 
 f35ffa1a54ccc4cd1ed7983aac792e334c9169b1
   SHA1 (patch-python_mozbuild_mozbuild_backend_recursivemake.py) = 
 ffb59ddf2d95eb284d24dad3d3aedc7d7f5b5d96
   SHA1 (patch-python_mozbuild_mozbuild_configure_constants.py) = 
 e90a88fba0643d02efb3c399aa22e5b9b225bc02
 +SHA1 (patch-python_mozbuild_mozbuild_virtualenv.py) = 
 73f13c50d7a2d5c722d00c93bcabb84b3ff34273
 cvs diff: Diffing patches
 Index: patches/patch-python_mozbuild_mozbuild_virtualenv.py
 ===================================================================
 RCS file: patches/patch-python_mozbuild_mozbuild_virtualenv.py
 diff -N patches/patch-python_mozbuild_mozbuild_virtualenv.py
 --- /dev/null   1 Jan 1970 00:00:00 -0000
 +++ patches/patch-python_mozbuild_mozbuild_virtualenv.py        2 Mar 
 2020 14:17:39 -0000
 @@ -0,0 +1,21 @@
 +$NetBSD$
 +
 +Remove a test that drives the Python environment to be reduild during 
 the
 +configure step. This bug seems esoteric since it only occurs when using
 +pbulk with sandbox.
 +
 +--- python/mozbuild/mozbuild/virtualenv.py.orig        2018-04-28 
 01:04:06.000000000 +0000
 ++++ python/mozbuild/mozbuild/virtualenv.py
 +@@ -122,12 +122,6 @@ class VirtualenvManager(object):
 +
 +             return False
 +
 +-        # check modification times
 +-        activate_mtime = os.path.getmtime(self.activate_path)
 +-        dep_mtime = max(os.path.getmtime(p) for p in deps)
 +-        if dep_mtime > activate_mtime:
 +-            return False
 +-
 +         # Verify that the Python we're checking here is either the 
 virutalenv
 +         # python, or we have the Python version that was used to 
 create the
 +         # virtualenv. If this fails, it is likely system Python has 
 been