pkg/54904: www/firefox building fails on FreeBSD

[triaxx%netbsd.org@localhost]

>Number:         54904
>Category:       pkg
>Synopsis:       www/firefox building fails on FreeBSD
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 28 12:35:00 +0000 2020
>Originator:     Frédéric Fauberteau
>Release:        FreeBSD 12.0-RELEASE-p12
>Organization:
>Environment:
System: FreeBSD cocoon.triaxx.org 12.0-RELEASE-p12 FreeBSD 12.0-RELEASE-p12 GENERIC  amd64
Architecture: x86_64
Machine: amd64
>Description:
The build set of www/firefox fails with the following log::
===> Building for firefox-72.0.2
[...]
/usr/pkgsrc/www/firefox/work/.cwrapper/bin/clang++ -o Compression.o -c  -I/usr/pkgsrc/www/firefox/work/build/dist/system_wrappers -include /usr/pkgsrc/www/firefox/work/firefox-72.0.2/config/gcc_hidden.h -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DIMPL_MFBT -DLZ4LIB_VISIBILITY= -I/usr/pkgsrc/www/firefox/work/firefox-72.0.2/mfbt -I/usr/pkgsrc/www/firefox/work/build/mfbt -I/usr/pkgsrc/www/firefox/work/firefox-72.0.2/mfbt/double-conversion -I/usr/pkgsrc/www/firefox/work/build/dist/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss -I/usr/pkg/include/nspr -I/usr/pkgsrc/www/firefox/work/build/dist/include/nss -I/usr/pkg/include/pixman-1 -fPIC -DMOZILLA_CLIENT -include /usr/pkgsrc/www/firefox/work/build/mozilla-config.h -Qunused-arguments -I/usr/pkg/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/pkg/include/libdrm -I/usr/include -I/usr/pkg/include/ncurses -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg
 /lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/pkg/include/freetype2 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fno-aligned-new -O
 2 -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -I/usr/pkg/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/pkg/include/libdrm -I/usr/include -I/usr/pkg/include/ncurses -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg4 -I/usr/pkg/include/freetype2 -D__HAVE_INLINE___ISINF -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -I/usr/pkg/include -O2 -fomit-frame-pointer -funwind-tables  -MD -MP -MF .deps/Compression.o.pp   /usr/pkgsrc/www/firefox/work/firefox-72.0.2/mfbt/Compression.cpp
In file included from /usr/pkgsrc/www/firefox/work/firefox-72.0.2/mfbt/Compression.cpp:7:
In file included from /usr/pkgsrc/www/firefox/work/build/dist/include/mozilla/Compression.h:14:
In file included from /usr/pkgsrc/www/firefox/work/build/dist/include/mozilla/Result.h:18:
In file included from /usr/pkgsrc/www/firefox/work/build/dist/include/mozilla/Variant.h:14:
In file included from /usr/pkgsrc/www/firefox/work/build/dist/include/mozilla/HashFunctions.h:53:
In file included from /usr/pkgsrc/www/firefox/work/build/dist/include/mozilla/MathAlgorithms.h:15:
In file included from /usr/pkgsrc/www/firefox/work/build/dist/system_wrappers/cmath:4:
In file included from /usr/include/c++/v1/cmath:305:
In file included from /usr/pkgsrc/www/firefox/work/build/dist/system_wrappers/math.h:4:
In file included from /usr/include/c++/v1/math.h:301:
/usr/include/math.h:187:5: error: conflicting types for '__builtin_isinf'
int     __isinf(double) __pure2;
        ^
/usr/pkgsrc/www/firefox/work/build/dist/system_wrappers/sys/cdefs.h:2:20: note: expanded from macro '__isinf'
#define __isinf(x) __builtin_isinf(x)
                   ^
/usr/include/math.h:187:5: note: '__builtin_isinf' is a builtin with type 'int (...) noexcept'
/usr/pkgsrc/www/firefox/work/build/dist/system_wrappers/sys/cdefs.h:2:20: note: expanded from macro '__isinf'
#define __isinf(x) __builtin_isinf(x)
                   ^
1 error generated.
gmake[3]: *** [/usr/pkgsrc/www/firefox/work/firefox-72.0.2/config/rules.mk:806: Compression.o] Error 1
gmake[3]: Leaving directory '/usr/pkgsrc/www/firefox/work/build/mfbt'
gmake[2]: *** [/usr/pkgsrc/www/firefox/work/firefox-72.0.2/config/recurse.mk:74: mfbt/target-objects] Error 2
gmake[2]: Leaving directory '/usr/pkgsrc/www/firefox/work/build'
gmake[1]: *** [/usr/pkgsrc/www/firefox/work/firefox-72.0.2/config/recurse.mk:34: compile] Error 2
gmake[1]: Leaving directory '/usr/pkgsrc/www/firefox/work/build'
gmake: *** [/usr/pkgsrc/www/firefox/work/firefox-72.0.2/config/rules.mk:394: all] Error 2
*** Error code 2

Stop.
bmake[1]: stopped in /usr/pkgsrc/www/firefox
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/www/firefox

The complete log is available here: http://pkg.triaxx.org/pub/pkgsrc/logs/devel/firefox/firefox-72.0.2/build.log
>How-To-Repeat:
cd /usr/pkgsrc/www/firefox && make build
>Fix: