pkg/54484: lang/newlisp build broken after NetBSD readline.h change

[Hauke Fath <hf%spg.tu-darmstadt.de@localhost>]

>Number:         54484
>Category:       pkg
>Synopsis:       lang/newlisp build broken after NetBSD readline.h change
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 20 09:40:00 +0000 2019
>Originator:     Hauke Fath
>Release:        NetBSD 9.0_BETA
>Organization:
Technische Universitaet Darmstadt
>Environment:
	
	
System: NetBSD Gstoder 9.0_BETA NetBSD 9.0_BETA (GA-MA770-UD3-$Revision$) #0: Mon Aug 5 16:36:12 CEST 2019 hf@Hochstuhl:/var/obj/netbsd-builds/9/amd64/sys/arch/amd64/compile/GA-MA770-UD3 amd64
Architecture: x86_64
Machine: amd64
>Description:

	The lang/newlisp build currently breaks with

[...]
gcc -m64 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -I/usr/pkg/include  -Wall -Wno-uninitialized -Wno-long-long -fno-strict-aliasing -O2 -c -DNEWCONFIG nl-list.c
--- newlisp.o ---
newlisp.c:1013:9: error: conflicting types for 'completion_matches'
 char ** completion_matches(const char * text,  char * (*commands)(const char *, int));
         ^~~~~~~~~~~~~~~~~~
In file included from newlisp.c:31:0:
/usr/include/readline/readline.h:183:15: note: previous declaration of 'completion_matches' was here
 char        **completion_matches(/* const */ char *, rl_compentry_func_t *);
               ^~~~~~~~~~~~~~~~~~
newlisp.c: In function 'printString':
newlisp.c:2712:25: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
                         else
                         ^~~~
newlisp.c:2713:45: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
                 varPrintf(device,"%c",chr); break;
                                             ^~~~~
newlisp.c: In function 'p_set':
newlisp.c:5129:5: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if(params == nilCell)
     ^~
newlisp.c:5131:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
  pushResultFlag = TRUE;
  ^~~~~~~~~~~~~~
newlisp.c: In function 'p_new':
newlisp.c:6633:5: warning: this 'else' clause does not guard... [-Wmisleading-indentation]
     else
     ^~~~
newlisp.c:6636:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else'
         overWriteFlag = (evaluateExpression(next)->type != CELL_NIL);
         ^~~~~~~~~~~~~
--- nl-liststr.o ---
gcc -m64 -O2 -D_FORTIFY_SOURCE=2 -I/usr/include -I/usr/pkg/include  -Wall -Wno-uninitialized -Wno-long-long -fno-strict-aliasing -O2 -c -DNEWCONFIG nl-liststr.c
--- newlisp.o ---
*** [newlisp.o] Error code 1

make[1]: stopped in /var/obj/pkgsrc/lang/newlisp/work/newlisp-10.7.1
1 error

	after the v1.43 commit to NetBSD src/lib/libedit/readline/readline.h.

	
>How-To-Repeat:

	Build newlisp on netbsd-9.

	
>Fix:

	De-constifying the prototype will break builds on netbsd-8;
	being unfamiliar with the code, I am not clear about the
	implications either way.

	I tried updating to 10.7.5, which did not make a difference.

	

>Unformatted: