Re: pkg/54483: New package: doas-6.1

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/54483; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/54483: New package: doas-6.1
Date: Mon, 19 Aug 2019 16:41:57 +0200

 Hello sxvghd,
 
 sxvghd%firemail.cc@localhost writes:
 > [...]
 > >Description:
 > The doas utility is a program originally written
 > for OpenBSD which allows a user to run a
 > command as though they were another user.
 > Typically doas is used to allow non-privleged
 > users to run commands as though they were
 > the root user. The doas program acts as an
 > alternative to sudo, which is a popular method
 > in the Linux ccommunity for granting admin
 > access to specific users.
 >
 > The doas program offers two benefits over sudo:
 > its configuration file has a simple syntax and it is
 > smaller, requiring less effort to audit the code.
 > >How-To-Repeat:
 >
 > >Fix:
 > begin 644 doas.tar.gz
 > [...]
 
 Thanks for the PR!
 
 I suggest to import this package in pkgsrc-wip to ease possible further
 testing and reviews, some suggestions directly in this email.
 
 In security/doas/Makefile I think that you can just set:
 
  DISTNAME= doas-6.1
 
 and then remove GITHUB_PROJECT, PKGNAME, DIST_SUBDIR and WRKSRC
 redefinition (this will also need a `make makesum' to update
 distinfo).
 
 For SUBST_STAGE.fix-paths please change it to `pre-configure', that's
 more consistent with other packages and ease debugging the SUBST
 earlier in the build process.
 
 The SUBST_SEDs are a bit problematic:
 
  SUBST_SED.fix-paths=    -e 's,$$(PREFIX)/man,$$(PKGMANDIR),g'
 
 ...shouldn't this be: $((PREFIX))/${PKGMANDIR} instead?
 
  SUBST_SED.fix-paths=    -e 's,$$(PREFIX),$$(DESTDIR)$$(PREFIX),g'
 
 ..this should have a `+=' (not just a `=') (because it's the 2nd sed
 command).  Also, adding DESTDIR support is probably worth to share with
 a patch upstream too (if you haven't already).
 
 Please also substitute hardcoded $(PREFIX)/etc with ${PKG_SYSCONFDIR}.
 
 The doas binary probably needs to be marked via SPECIAL_PERMS as
 ${SETUID_ROOT_PERMS} (for a possible example please give a look to
 security/sudo).
 
 `yacc' seems used, please add it to USE_TOOLS too.
 Usually USE_TOOLS is added as the 4th paragraph just after WRKSRC
 definition.
 
 `pam' seems used unconditionally, doesn't that need to include
 "../../mk/pam.buildlink3.mk"?  If pam support is optional it's probably
 worth to add a `pam' option to permit users to enable/disable it.
 
 
 Thanks!