pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/54109: pkgsrc-2019Q1 www/webkit-gtk build fails on NetBSD/i386 8.0



The following reply was made to PR pkg/54109; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/54109: pkgsrc-2019Q1 www/webkit-gtk build fails on NetBSD/i386 8.0
Date: Tue, 09 Apr 2019 17:59:48 +0200

 Leonardo Taccari writes:
 > [...]  
 >  to:
 >  
 >   | #
 >   | # JIT support
 >   | #
 >   | .if !empty(PKG_OPTIONS:Mwebkit-jit)
 >   | CMAKE_ARGS+=    -DENABLE_JIT=ON
 >   | CMAKE_ARGS+=    -DENABLE_C_LOOP=OFF
 >   | .else
 >   | CMAKE_ARGS+=    -DENABLE_JIT=OFF
 >   | CMAKE_ARGS+=    -DENABLE_C_LOOP=ON
 >   | .endif
 > [...]  
 
 ...I think it's better to modify it to:
 
   | #
   | # JIT support
   | #
   | .if !empty(PKG_OPTIONS:Mwebkit-jit)
   | CMAKE_ARGS+=    -DENABLE_JIT=ON
   | CMAKE_ARGS+=    -DENABLE_C_LOOP=OFF
   | .else
   | CMAKE_ARGS+=    -DENABLE_JIT=OFF
   | .endif
 
 (i.e. not adjusting ENABLE_C_LOOP when webkit-jit is not provided.)
 


Home | Main Index | Thread Index | Old Index