Re: pkg/54109: pkgsrc-2019Q1 www/webkit-gtk build fails on NetBSD/i386 8.0

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/54109; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/54109: pkgsrc-2019Q1 www/webkit-gtk build fails on NetBSD/i386 8.0
Date: Tue, 09 Apr 2019 17:45:57 +0200

 Hello Izumi,
 
 Izumi Tsutsui writes:
 > >Number:         54109
 > >Category:       pkg
 > >Synopsis:       pkgsrc-2019Q1 www/webkit-gtk build fails on NetBSD/i386 8.0
 > >Confidential:   no
 > >Severity:       non-critical
 > >Priority:       medium
 > >Responsible:    pkg-manager
 > >State:          open
 > >Class:          sw-bug
 > >Submitter-Id:   net
 > >Arrival-Date:   Tue Apr 09 14:40:02 +0000 2019
 > >Originator:     Izumi Tsutsui
 > >Release:        NetBSD 8.0 + pkgsrc-2019Q1
 > >Organization:
 > [...]
 > CMake Error at Source/cmake/WebKitFeatures.cmake:275 (message):
 >   ENABLE_JIT conflicts with ENABLE_C_LOOP.  You must disable one or the
 >   other.
 > Call Stack (most recent call first):
 > [...]
 > >Fix:
 > It looks removing "NetBSD-*-i386" from WEBKIT_JIT_MACHINE_PLATFORMS
 > in options.mk works around.
 > [...]
 
 Unfortunately it seems that from 2.22.6 to 2.24.0 the defaults were
 changed (and I have missed that on the changelogs or were not
 documented, sorry!).
 
 Can you please let me know if adjusting the webkit-jit handling from:
 
  | #
  | # JIT support
  | #
  | .if !empty(PKG_OPTIONS:Mwebkit-jit)
  | CMAKE_ARGS+=    -DENABLE_JIT=ON
  | .else
  | CMAKE_ARGS+=    -DENABLE_JIT=OFF
  | .endif
 
 to:
 
  | #
  | # JIT support
  | #
  | .if !empty(PKG_OPTIONS:Mwebkit-jit)
  | CMAKE_ARGS+=    -DENABLE_JIT=ON
  | CMAKE_ARGS+=    -DENABLE_C_LOOP=OFF
  | .else
  | CMAKE_ARGS+=    -DENABLE_JIT=OFF
  | CMAKE_ARGS+=    -DENABLE_C_LOOP=ON
  | .endif
 
 fixes that?
 
 (It would be great if you can also try to run
 libexec/webkit2gtk-4.0/MiniBrowser or any other webkit-gtk browser
 and if they works that's probably okay (also the non-CMake logic
 does the same))
 
 Apart that I will try to investigate further about this change and
 eventually adjust WEBKIT_JIT_MACHINE_PLATFORMS per-CMake logic.
 
 
 Thank you!