Re: pkg/53369: audio/mpg321 coredumps with SIGSEGV

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/53369; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53369: audio/mpg321 coredumps with SIGSEGV
Date: Sat, 16 Jun 2018 16:54:19 +0200

 Hello Sevan,
 
 Sevan Janiyan writes:
 >  Thank you, that fixes the crash.
 
 Neat, thank you for the quick feedback!
 
 >  There is an aggressive mode which tries to execute mpg321 at a higher
 >  priority, does sem_post() fit in that situation?
 >  
 
 At least the sem_post() removed I think wasn't related to that.
 
 >  It seems I've gotten into a bit of a rabbit hole, while mpg321 now does
 >  crash initially, it plays MP3 files at the wrong pitch (everything is
 >  way too high) and it eventually crashes if I point it to a wav file.
 >  There's a patch in Free/OpenBSD ports which cleans up some bugs in
 >  mpg321.c that will be usefull to pull in (don't leak file descriptors or
 >  free random pointers). I will raise separate bug reports for these.
 
 Whooops! At least on amd64 -current seems to works pretty well with some
 $RANDOM mp3 files. Probably yes, please fill separate PRs (and if
 possible please also share problematic mp3/wav files or URLs to them if
 they are under free licenses).