Re: pkg/53369: audio/mpg321 coredumps with SIGSEGV

[Sevan Janiyan <venture37%geeklan.co.uk@localhost>]

The following reply was made to PR pkg/53369; it has been noted by GNATS.

From: Sevan Janiyan <venture37%geeklan.co.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53369: audio/mpg321 coredumps with SIGSEGV
Date: Sat, 16 Jun 2018 15:22:33 +0100

 On 16/06/2018 11:45, Leonardo Taccari wrote:
 >  As pointed out by <maya> it seems that there is a sem_post() on a
 >  not initialized semaphore.
 >  
 >  The following patch seems to fix the problem (if I am not missing
 >  something there is no need to call sem_post() at all in that case and can
 >  be removed):
 >  
 >   <https://www.NetBSD.org/~leot/pkgsrc-patches/mpg321-pkg-53369.patch>
 >  
 >  Please let us known if that fixes the problem!
 
 Thank you, that fixes the crash.
 There is an aggressive mode which tries to execute mpg321 at a higher
 priority, does sem_post() fit in that situation?
 
 It seems I've gotten into a bit of a rabbit hole, while mpg321 now does
 crash initially, it plays MP3 files at the wrong pitch (everything is
 way too high) and it eventually crashes if I point it to a wav file.
 There's a patch in Free/OpenBSD ports which cleans up some bugs in
 mpg321.c that will be usefull to pull in (don't leak file descriptors or
 free random pointers). I will raise separate bug reports for these.
 
 
 Sevan