pkg/53290: snmptrapd's rc file doesn't remove pidfile on stop

[ef%math.uni-bonn.de@localhost]

>Number:         53290
>Category:       pkg
>Synopsis:       snmptrapd's rc file doesn't remove pidfile on stop
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 15 15:15:00 +0000 2018
>Originator:     Edgar FuÃ?
>Release:        pkgsrc-2017Q3
>Organization:
Mathematisches Institut der Universität Bonn
>Description:
	On stop, the snmptrapd rc file provided by net/net-snmp
	doesn't delete the PID file, making, i.e. the monitoring
	check_pid plugin barf.
>How-To-Repeat:
	/etc/rc.d/snmptrapd start; /etc/rc.d/snmptrapd stop; ls /var/run/snmptrad.pid
>Fix:
	Index: Makefile
	===================================================================
	RCS file: /cvsroot/pkgsrc/net/net-snmp/Makefile,v
	retrieving revision 1.120
	diff -u -r1.120 Makefile
	--- Makefile	23 Jul 2017 17:43:33 -0000	1.120
	+++ Makefile	15 May 2018 15:05:51 -0000
	@@ -2,7 +2,7 @@
	 
	 .include "Makefile.common"
	 CATEGORIES=	net
	-PKGREVISION=	7
	+PKGREVISION=	8
	 
	 MAINTAINER=	adam%NetBSD.org@localhost
	 COMMENT=	Extensible SNMP implementation
	Index: files/snmptrapd.sh
	===================================================================
	RCS file: /cvsroot/pkgsrc/net/net-snmp/files/snmptrapd.sh,v
	retrieving revision 1.5
	diff -u -r1.5 snmptrapd.sh
	--- files/snmptrapd.sh	22 Oct 2011 07:33:34 -0000	1.5
	+++ files/snmptrapd.sh	15 May 2018 15:05:51 -0000
	@@ -16,6 +16,7 @@
	 command="@PREFIX@/sbin/${name}"
	 pidfile="/var/run/${name}.pid"
	 command_args="-p ${pidfile}"
	+stop_postcmd="rm -f ${pidfile}"
	 
	 if [ -f @PKG_SYSCONFDIR@/snmptrapd.conf ]; then
		command_args="${command_args} -c @PKG_SYSCONFDIR@/snmptrapd.conf"