Re: pkg/52241 (graphics/netpbm does not compile on Solaris 10)

[Jonathan Perkin <jperkin%joyent.com@localhost>]

The following reply was made to PR pkg/52241; it has been noted by GNATS.

From: Jonathan Perkin <jperkin%joyent.com@localhost>
To: Joern Clausen <joern.clausen%uni-bielefeld.de@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, adam%NetBSD.org@localhost, pkgsrc-bugs%NetBSD.org@localhost,
	gnats-admin%NetBSD.org@localhost, dholland%NetBSD.org@localhost
Subject: Re: pkg/52241 (graphics/netpbm does not compile on Solaris 10)
Date: Wed, 21 Feb 2018 14:35:07 +0000

 * On 2018-02-21 at 14:27 GMT, Joern Clausen wrote:
 
 > > Is that sufficient?
 > 
 > Yes and no...
 > 
 > buildtools/stamp-date is now executed, but the generated file "compile.h"
 > contains
 > 
 > #define BUILD_DATETIME %s
 > 
 > because Solaris-10's "date" (or strftime, to be precise) does not know about
 > "%s". This breaks compilation of libpm.c.
 > 
 > I'm pretty sure that when I opened the PR, replacing the shell was the only
 > fix necessary. Either BUILD_DATETIME wasn't there, or someone changed the
 > format definition? Judging from the use of BUILD_DATETIME in libpm.c,
 > anything else than a numeral should not work. I personally would prefer
 > 
 > date +%Y%m%d%H%M%S
 > 
 > as it is more readable anyway. Using gdate is probably the easier fix in
 > pkgsrc, though.
 
 The better fix would be to remove it completely so that we move one
 step closer to reproducible builds.
 
 -- 
 Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com