pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/52241 (graphics/netpbm does not compile on Solaris 10)

The following reply was made to PR pkg/52241; it has been noted by GNATS.

From: Joern Clausen <>
Subject: Re: pkg/52241 (graphics/netpbm does not compile on Solaris 10)
Date: Wed, 21 Feb 2018 15:26:57 +0100

 > Is that sufficient?
 Yes and no...
 buildtools/stamp-date is now executed, but the generated file 
 "compile.h" contains
 #define BUILD_DATETIME %s
 because Solaris-10's "date" (or strftime, to be precise) does not know 
 about "%s". This breaks compilation of libpm.c.
 I'm pretty sure that when I opened the PR, replacing the shell was the 
 only fix necessary. Either BUILD_DATETIME wasn't there, or someone 
 changed the format definition? Judging from the use of BUILD_DATETIME in 
 libpm.c, anything else than a numeral should not work. I personally 
 would prefer
 date +%Y%m%d%H%M%S
 as it is more readable anyway. Using gdate is probably the easier fix in 
 pkgsrc, though.
 Jörn Clausen
 Plattformen & Serverdienste
 BITS - Bielefelder IT-Servicezentrum
 Universität Bielefeld
 Universitätsstraße 25
 33615 Bielefeld
 Telefon: +49 521 106-12601

Home | Main Index | Thread Index | Old Index