Re: pkg/52667: devel/libidn2 failing to build

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/52667; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/52667: devel/libidn2 failing to build
Date: Sun, 29 Oct 2017 00:08:55 +0200

 Hello scole!
 
 scole_mail%gmx.com@localhost writes:
 > [...]
 > >Description:
 > libidn2-2.0.4 isn't building for me, seems to be related to pkg-config.
 > [...]
 > Traceback (most recent call last):
 >   File "/home/scole/pkg/bin/gtkdoc-rebase", line 56, in <module>
 >     sys.exit(rebase.run(options))
 >   File "/home/scole/pkg/share/gtk-doc/python/gtkdoc/rebase.py", line 66,=
  in run
 >     dir =3D common.GetModuleDocDir('glib-2.0')
 >   File "/home/scole/pkg/share/gtk-doc/python/gtkdoc/common.py", line 104=
 , in GetModuleDocDir
 >     path =3D subprocess.check_output([config.pkg_config, '--variable=3Dp=
 refix', module_name], universal_newlines=3DTrue)
 >   File "/home/scole/pkg/lib/python2.7/subprocess.py", line 219, in check=
 _output
 >     raise CalledProcessError(retcode, cmd, output=3Doutput)
 > subprocess.CalledProcessError: Command '['pkg-config', '--variable=3Dpre=
 fix', 'glib-2.0']' returned non-zero exit status 1
 > *** Error code 1
 >
 > if I look in work/.pkg-config.log =
 
 >  glib-2.0 NOT-FOUND
 >
 > [...]
 
 Yes, the problem at the end is a missing dependency to glib-2.0 but the
 real problem is that gtkdoc-rebase and other gtkdoc-* tools are picked
 up unconditionally despite the package is configured with
 `--disable-gtk-doc' by default (this happens because you probably have
 the `gtk-doc' package already installed, for a longer analysis please
 give a look to PR pkg/52632).
 
 > [...]
 > >Fix:
 > Don't know if this is correct, but adding glib2 buildlink3 worked for me=
 .
 >
 > Apply patch with "cd .../pkgsrc/devel/libidn2 ; patch -s -p0 < .../patch=
 file"
 > [...]
 
 I think it's not needed and unfortunately also here we need to apply a
 kludge to avoid picking up `gtkdoc-*' tools the hard way.
 
 Can you please test the following patch and let us known if it fixes the
 problem?:
 
  <https://NetBSD.org/~leot/pkgsrc-patches/libidn2-gtk-doc-fixes.patch>
 
 For completeness at the end of the email you can find an attached
 version inline.
 
 
 Thank you!
 
 
 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/devel/libidn2/Makefile,v
 retrieving revision 1.4
 diff -u -p -r1.4 Makefile
 --- Makefile	30 Aug 2017 15:22:30 -0000	1.4
 +++ Makefile	28 Oct 2017 21:57:02 -0000
 @@ -15,6 +15,13 @@ GNU_CONFIGURE=3D		yes
  PKGCONFIG_OVERRIDE+=3D	libidn2.pc.in
  INFO_FILES=3D		yes
  =
 
 +# XXX: Kludge to avoid uncoditionally pick up some gtkdoc-* tools if gtk-=
 doc
 +# XXX: package is installed and then fails in the installation phase.
 +CONFIGURE_ENV+=3D		ac_cv_prog_GTKDOC_CHECK=3D \
 +			ac_cv_path_GTKDOC_CHECK_PATH=3D \
 +			ac_cv_path_GTKDOC_REBASE=3D \
 +			ac_cv_path_GTKDOC_MKPDF=3D
 +
  .include "../../converters/libiconv/buildlink3.mk"
  .include "../../devel/gettext-lib/buildlink3.mk"
  .include "../../textproc/libunistring/buildlink3.mk"