pkg/52667: devel/libidn2 failing to build

[scole_mail%gmx.com@localhost]

>Number:         52667
>Category:       pkg
>Synopsis:       devel/libidn2 failing to build
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 28 21:40:00 +0000 2017
>Originator:     scole_mail
>Release:        pkgsrc current
>Organization:
none
>Environment:
NetBSD dstar 7.1.0_PATCH NetBSD 7.1.0_PATCH (GENERIC) #0: Fri Sep  8 20:45:12 PDT 2017  scole@dstar:/home/scole/nbsd/cvs/7_0/obj/sys/arch/i386/compile/GENERIC i386

>Description:
libidn2-2.0.4 isn't building for me, seems to be related to pkg-config.

...
Making install in doc
/home/scole/pkg/bin/bmake  install-recursive
Making install in reference
 /usr/bin/install -c -o scole -g users -m 644 ./html/api-index-full.html
 /usr/bin/install -c -o scole -g users -m 644 ./html/home.png
 /usr/bin/install -c -o scole -g users -m 644 ./html/index.html
 /usr/bin/install -c -o scole -g users -m 644 ./html/left-insensitive.png
 /usr/bin/install -c -o scole -g users -m 644 ./html/left.png
 /usr/bin/install -c -o scole -g users -m 644 ./html/libidn2-idn2.html
 /usr/bin/install -c -o scole -g users -m 644 ./html/libidn2.devhelp2
 /usr/bin/install -c -o scole -g users -m 644 ./html/libidn2.html
 /usr/bin/install -c -o scole -g users -m 644 ./html/right-insensitive.png
 /usr/bin/install -c -o scole -g users -m 644 ./html/right.png
 /usr/bin/install -c -o scole -g users -m 644 ./html/style.css
 /usr/bin/install -c -o scole -g users -m 644 ./html/up-insensitive.png
 /usr/bin/install -c -o scole -g users -m 644 ./html/up.png
Traceback (most recent call last):
  File "/home/scole/pkg/bin/gtkdoc-rebase", line 56, in <module>
    sys.exit(rebase.run(options))
  File "/home/scole/pkg/share/gtk-doc/python/gtkdoc/rebase.py", line 66, in run
    dir = common.GetModuleDocDir('glib-2.0')
  File "/home/scole/pkg/share/gtk-doc/python/gtkdoc/common.py", line 104, in GetModuleDocDir
    path = subprocess.check_output([config.pkg_config, '--variable=prefix', module_name], universal_newlines=True)
  File "/home/scole/pkg/lib/python2.7/subprocess.py", line 219, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['pkg-config', '--variable=prefix', 'glib-2.0']' returned non-zero exit status 1
*** Error code 1

if I look in work/.pkg-config.log 
 glib-2.0 NOT-FOUND

Not sure if it matters, but I'm using unprivileged pkgsrc in my home dir and not /usr/pkgsrc

>How-To-Repeat:
cd .../pkgsrc/devel/libidn2 && bmake

>Fix:
Don't know if this is correct, but adding glib2 buildlink3 worked for me.

Apply patch with "cd .../pkgsrc/devel/libidn2 ; patch -s -p0 < .../patchfile"

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/libidn2/Makefile,v
retrieving revision 1.4
diff -b -u -r1.4 Makefile
--- Makefile    30 Aug 2017 15:22:30 -0000      1.4
+++ Makefile    28 Oct 2017 21:33:44 -0000
@@ -17,5 +17,6 @@
 
 .include "../../converters/libiconv/buildlink3.mk"
 .include "../../devel/gettext-lib/buildlink3.mk"
+.include "../../devel/glib2/buildlink3.mk"
 .include "../../textproc/libunistring/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"