Re: pkg/51757 (pkgsrc/editor/emacs doesn't build default emacs-25.1)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/51757; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/51757 (pkgsrc/editor/emacs doesn't build default emacs-25.1)
Date: Sun, 1 Jan 2017 05:07:38 +0000

 On Sun, Jan 01, 2017 at 03:40:00AM +0000, Izumi Tsutsui wrote:
  >  Have you actually confirmed it?
 
 It's straightforward. Does it fail?
 
  >  >> --- pkgsrc/editors/emacs/Makefile.common:1.40   Sat Feb 23 23:36:49 2013
  >  >> +++ pkgsrc/editors/emacs/Makefile.common        Sun Jan  1 02:06:46 2017
  >   :
  >  >> @@ -38,7 +38,7 @@ PKG_FAIL_REASON+=     "EMACS_TYPE is xemacs.
  >  >>  # (Set these to avoid crashing out below.)
  >  >>  EMACS_PKGDIR=          ../../editors/xemacs
  >  >>  EMACS_PACKAGE=         xemacs
  >  >> -.elif ${MY_EMACS_TYPE} == "emacs25"
  >  >> +.elif ${MY_EMACS_TYPE} == "emacs26"
  >  >>  EMACS_PKGDIR=          ../../editors/emacs-snapshot
  >  
  >  editors/emacs-snapshot looks older then 25.1,
 
 Yes, but it'll turn into emacs26 eventually. It makes more sense to
 leave the hook in labeled emacs26 (which isn't an officially supported
 EMACS_TYPE yet) then to take it out and put it back later and maybe
 get it wrong then.
 
  >  and no VER and REV values are defined for emacs25*:
 
 Yes they are:
 
  >  .else
  >  VER=	${_EMACS_VERSION_MAJOR}
  >  REV=	0
  >  .endif
 
 which is fine, if you read the comment explaining what those versions
 are for.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost