Re: pkg/51757 (pkgsrc/editor/emacs doesn't build default emacs-25.1)

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR pkg/51757; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: dholland%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: pkg/51757 (pkgsrc/editor/emacs doesn't build default emacs-25.1)
Date: Sun, 1 Jan 2017 12:36:17 +0900

 > State-Changed-From-To: open->closed
 > State-Changed-By: dholland%NetBSD.org@localhost
 > State-Changed-When: Sun, 01 Jan 2017 02:47:21 +0000
 > State-Changed-Why:
 > already fixed
 
 Have you actually confirmed it?
 
 >> --- pkgsrc/editors/emacs/Makefile.common:1.40   Sat Feb 23 23:36:49 2013
 >> +++ pkgsrc/editors/emacs/Makefile.common        Sun Jan  1 02:06:46 2017
  :
 >> @@ -38,7 +38,7 @@ PKG_FAIL_REASON+=     "EMACS_TYPE is xemacs.
 >>  # (Set these to avoid crashing out below.)
 >>  EMACS_PKGDIR=          ../../editors/xemacs
 >>  EMACS_PACKAGE=         xemacs
 >> -.elif ${MY_EMACS_TYPE} == "emacs25"
 >> +.elif ${MY_EMACS_TYPE} == "emacs26"
 >>  EMACS_PKGDIR=          ../../editors/emacs-snapshot
 
 editors/emacs-snapshot looks older then 25.1,
 and no VER and REV values are defined for emacs25*:
  http://cvsweb.netbsd.org/bsdweb.cgi/pkgsrc/editors/emacs/Makefile.common?rev=1.41&content-type=text/x-cvsweb-markup
 
 ---
 # 2. Now it gets gross. Before this meta-package was introduced, the
 # emacs packages all had PKGNAME set to "emacs". Now the meta-package
 # is called "emacs" and the emacs packages themselves have the emacs
 # major version in them. But in order to make updates work properly,
 # the version of the package called "emacs" cannot go down. We need to
 # set MY_EMACS_VERSION accordingly. The following were the versions at
 # the time the renaming was done:
 #   emacs20		20.7nb16
 #   emacs21		21.4anb26
 #   emacs21-nox11	21.4anb13
 #   emacs22		22.3nb26
 #   emacs22-nox11	22.3nb3
 #   emacs23		23.4nb12
 #   emacs23-nox11	23.4nb1
 #   emacs24		24.2nb6
 #   emacs24-nox11	24.2
 #   emacs25+		n/a
 #
 # Set VER to the version from the above table, and REV to the
 # PKGREVISION value.
 #
 
 .if ${MY_EMACS_TYPE} == "emacs20"
 VER=	20.7
 REV=	16
 .elif ${MY_EMACS_TYPE} == "emacs21"
 VER=	21.4
 REV=	26
 .elif ${MY_EMACS_TYPE} == "emacs21nox"
 VER=	21.4
 REV=	13
 .elif ${MY_EMACS_TYPE} == "emacs22"
 VER=	22.3
 REV=	26
 .elif ${MY_EMACS_TYPE} == "emacs22nox"
 VER=	22.3
 REV=	3
 .elif ${MY_EMACS_TYPE} == "emacs23"
 VER=	23.4
 REV=	12
 .elif ${MY_EMACS_TYPE} == "emacs23nox"
 VER=	23.4
 REV=	1
 .elif ${MY_EMACS_TYPE} == "emacs24"
 VER=	24.2
 REV=	6
 .elif ${MY_EMACS_TYPE} == "emacs24nox"
 VER=	24.2
 REV=	0
 .else
 VER=	${_EMACS_VERSION_MAJOR}
 REV=	0
 .endif
 ---
 
 (I have no idea why it has manual copies though)
 
 ---
 Izumi Tsutsui