pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/51481 (librsync 2.0.0 has crashing regression on OS X)

The following reply was made to PR pkg/51481; it has been noted by GNATS.

From: Andy Carrel <wac%google.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
	dholland%netbsd.org@localhost
Subject: Re: pkg/51481 (librsync 2.0.0 has crashing regression on OS X)
Date: Mon, 19 Sep 2016 13:16:01 -0700

 --001a114336c0573c6a053ce1fc76
 Content-Type: text/plain; charset=UTF-8
 
 Ugh. My apologies. Here you go...
 
 I haven't done the RCS id on the patchfile which looks like it's common in
 pkgsrc, that'll change the checksum as well.
 
 diff -r 6efb1b750b38 net/librsync/Makefile
 --- a/net/librsync/Makefile Fri Sep 16 09:42:25 2016 +0000
 +++ b/net/librsync/Makefile Mon Sep 19 13:12:00 2016 -0700
 @@ -1,6 +1,7 @@
  # $NetBSD: Makefile,v 1.3 2016/09/01 16:16:55 wiz Exp $
 
  DISTNAME= librsync-2.0.0
 +PKGREVISION= 1
  CATEGORIES= net
  MASTER_SITES= ${MASTER_SITE_GITHUB:=librsync/}
  GITHUB_TAG= v${PKGVERSION_NOREV}
 diff -r 6efb1b750b38 net/librsync/distinfo
 --- a/net/librsync/distinfo Fri Sep 16 09:42:25 2016 +0000
 +++ b/net/librsync/distinfo Mon Sep 19 13:12:00 2016 -0700
 @@ -4,3 +4,4 @@
  RMD160 (librsync-2.0.0.tar.gz) = f44284c0d33b9fb6a9b8c107169549cf2d121273
  SHA512 (librsync-2.0.0.tar.gz) =
 1a88dcc3aa60949e058c57eb0df3e0086823c493de40fed927246f5aada6274db57202074456a0ce5d9aa8b81b41836b0d6221ded6a75d43829572584177e8c0
  Size (librsync-2.0.0.tar.gz) = 155049 bytes
 +SHA1 (patch-search.c) = 4c64cdf5740b72f37f8f0a3664338365e14668b4
 diff -r 6efb1b750b38 net/librsync/patches/patch-search.c
 --- /dev/null Thu Jan 01 00:00:00 1970 +0000
 +++ b/net/librsync/patches/patch-search.c Mon Sep 19 13:12:00 2016 -0700
 @@ -0,0 +1,11 @@
 +--- src/search.c.orig 2016-09-16 14:04:07.000000000 -0700
 ++++ src/search.c 2016-09-16 14:05:01.000000000 -0700
 +@@ -218,7 +218,7 @@
 +    r = m;
 +     }
 +
 +-    if (l == r) {
 ++    if ((l == r) && (l <= bucket->r)) {
 + int i = sig->targets[l].i;
 + rs_block_sig_t *b = &(sig->block_sigs[i]);
 + if (weak_sum != b->weak_sum)
 
 On Sat, Sep 17, 2016 at 4:50 PM, <dholland%netbsd.org@localhost> wrote:
 
 > Synopsis: librsync 2.0.0 has crashing regression on OS X
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: dholland%NetBSD.org@localhost
 > State-Changed-When: Sat, 17 Sep 2016 23:50:08 +0000
 > State-Changed-Why:
 > you forgot to include the actual patch :-)
 >
 >
 >
 >
 
 
 -- 
 wac%google.com@localhost
 
 --001a114336c0573c6a053ce1fc76
 Content-Type: text/html; charset=UTF-8
 Content-Transfer-Encoding: quoted-printable
 
 <div dir=3D"ltr">Ugh. My apologies. Here you go...<div><br></div><div>I hav=
 en&#39;t done the RCS id on the patchfile which looks like it&#39;s common =
 in pkgsrc, that&#39;ll change the checksum as well.<br><div><br></div><div>=
 <div>diff -r 6efb1b750b38 net/librsync/Makefile</div><div>--- a/net/librsyn=
 c/Makefile<span class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	<=
 /span>Fri Sep 16 09:42:25 2016 +0000</div><div>+++ b/net/librsync/Makefile<=
 span class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	</span>Mon S=
 ep 19 13:12:00 2016 -0700</div><div>@@ -1,6 +1,7 @@</div><div>=C2=A0# $NetB=
 SD: Makefile,v 1.3 2016/09/01 16:16:55 wiz Exp $</div><div><br></div><div>=
 =C2=A0DISTNAME=3D<span class=3D"gmail-Apple-tab-span" style=3D"white-space:=
 pre">	</span>librsync-2.0.0</div><div>+PKGREVISION=3D<span class=3D"gmail-A=
 pple-tab-span" style=3D"white-space:pre">	</span>1</div><div>=C2=A0CATEGORI=
 ES=3D<span class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	</span=
 >net</div><div>=C2=A0MASTER_SITES=3D<span class=3D"gmail-Apple-tab-span" st=
 yle=3D"white-space:pre">	</span>${MASTER_SITE_GITHUB:=3Dlibrsync/}</div><di=
 v>=C2=A0GITHUB_TAG=3D<span class=3D"gmail-Apple-tab-span" style=3D"white-sp=
 ace:pre">	</span>v${PKGVERSION_NOREV}</div><div>diff -r 6efb1b750b38 net/li=
 brsync/distinfo</div><div>--- a/net/librsync/distinfo<span class=3D"gmail-A=
 pple-tab-span" style=3D"white-space:pre">	</span>Fri Sep 16 09:42:25 2016 +=
 0000</div><div>+++ b/net/librsync/distinfo<span class=3D"gmail-Apple-tab-sp=
 an" style=3D"white-space:pre">	</span>Mon Sep 19 13:12:00 2016 -0700</div><=
 div>@@ -4,3 +4,4 @@</div><div>=C2=A0RMD160 (librsync-2.0.0.tar.gz) =3D f442=
 84c0d33b9fb6a9b8c107169549cf2d121273</div><div>=C2=A0SHA512 (librsync-2.0.0=
 .tar.gz) =3D 1a88dcc3aa60949e058c57eb0df3e0086823c493de40fed927246f5aada627=
 4db57202074456a0ce5d9aa8b81b41836b0d6221ded6a75d43829572584177e8c0</div><di=
 v>=C2=A0Size (librsync-2.0.0.tar.gz) =3D 155049 bytes</div><div>+SHA1 (patc=
 h-search.c) =3D 4c64cdf5740b72f37f8f0a3664338365e14668b4</div><div>diff -r =
 6efb1b750b38 net/librsync/patches/patch-search.c</div><div>--- /dev/null<sp=
 an class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	</span>Thu Jan=
  01 00:00:00 1970 +0000</div><div>+++ b/net/librsync/patches/patch-search.c=
 <span class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	</span>Mon =
 Sep 19 13:12:00 2016 -0700</div><div>@@ -0,0 +1,11 @@</div><div>+--- src/se=
 arch.c.orig<span class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	=
 </span>2016-09-16 14:04:07.000000000 -0700</div><div>++++ src/search.c<span=
  class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	</span>2016-09-1=
 6 14:05:01.000000000 -0700</div><div>+@@ -218,7 +218,7 @@</div><div>+ <span=
  class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	</span> =C2=A0 =
 =C2=A0r =3D m;</div><div>+ =C2=A0 =C2=A0 }</div><div>+</div><div>+- =C2=A0 =
 =C2=A0if (l =3D=3D r) {</div><div>++ =C2=A0 =C2=A0if ((l =3D=3D r) &amp;&am=
 p; (l &lt;=3D bucket-&gt;r)) {</div><div>+ <span class=3D"gmail-Apple-tab-s=
 pan" style=3D"white-space:pre">	</span>int i =3D sig-&gt;targets[l].i;</div=
 ><div>+ <span class=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	</s=
 pan>rs_block_sig_t *b =3D &amp;(sig-&gt;block_sigs[i]);</div><div>+ <span c=
 lass=3D"gmail-Apple-tab-span" style=3D"white-space:pre">	</span>if (weak_su=
 m !=3D b-&gt;weak_sum)</div></div></div></div><div class=3D"gmail_extra"><b=
 r><div class=3D"gmail_quote">On Sat, Sep 17, 2016 at 4:50 PM,  <span dir=3D=
 "ltr">&lt;<a href=3D"mailto:dholland%netbsd.org@localhost"; target=3D"_blank">dholland=
 @netbsd.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" styl=
 e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Synopsi=
 s: librsync 2.0.0 has crashing regression on OS X<br>
 <br>
 State-Changed-From-To: open-&gt;feedback<br>
 State-Changed-By: dholland%NetBSD.org@localhost<br>
 State-Changed-When: Sat, 17 Sep 2016 23:50:08 +0000<br>
 State-Changed-Why:<br>
 you forgot to include the actual patch :-)<br>
 <br>
 <br>
 <br>
 </blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div class=
 =3D"gmail_signature" data-smartmail=3D"gmail_signature"><div style=3D"color=
 :rgb(85,85,85);font-family:Orbitron,monospace;font-size:x-small"><span styl=
 e=3D"border-top-width:0px;border-right-width:0px;border-bottom-width:2px;bo=
 rder-left-width:0px;border-top-style:solid;border-right-style:solid;border-=
 bottom-style:solid;border-left-style:solid;border-top-color:rgb(51,105,232)=
 ;border-right-color:rgb(51,105,232);border-bottom-color:rgb(51,105,232);bor=
 der-left-color:rgb(51,105,232);padding-top:2px;margin-top:2px;padding-left:=
 3px;padding-right:3px">w</span><span style=3D"border-top-width:0px;border-r=
 ight-width:0px;border-bottom-width:2px;border-left-width:0px;border-top-sty=
 le:solid;border-right-style:solid;border-bottom-style:solid;border-left-sty=
 le:solid;border-top-color:rgb(213,15,37);border-right-color:rgb(213,15,37);=
 border-bottom-color:rgb(213,15,37);border-left-color:rgb(213,15,37);padding=
 -top:2px;margin-top:2px;padding-left:3px;padding-right:3px">a</span><span s=
 tyle=3D"border-top-width:0px;border-right-width:0px;border-bottom-width:2px=
 ;border-left-width:0px;border-top-style:solid;border-right-style:solid;bord=
 er-bottom-style:solid;border-left-style:solid;border-top-color:rgb(238,178,=
 17);border-right-color:rgb(238,178,17);border-bottom-color:rgb(238,178,17);=
 border-left-color:rgb(238,178,17);padding-top:2px;padding-left:3px;padding-=
 right:3px;margin-top:2px">c</span><span style=3D"border-top-width:0px;borde=
 r-right-width:0px;border-bottom-width:2px;border-left-width:0px;border-top-=
 style:solid;border-right-style:solid;border-bottom-style:solid;border-left-=
 style:solid;border-top-color:rgb(51,105,232);border-right-color:rgb(51,105,=
 232);border-bottom-color:rgb(51,105,232);border-left-color:rgb(51,105,232);=
 padding-top:2px;margin-top:2px;padding-left:3px;padding-right:3px">@</span>=
 <span style=3D"border-top-width:0px;border-right-width:0px;border-bottom-wi=
 dth:2px;border-left-width:0px;border-top-style:solid;border-right-style:sol=
 id;border-bottom-style:solid;border-left-style:solid;border-top-color:rgb(0=
 ,153,57);border-right-color:rgb(0,153,57);border-bottom-color:rgb(0,153,57)=
 ;border-left-color:rgb(0,153,57);padding-top:2px;padding-left:3px;padding-r=
 ight:3px;margin-top:2px">google</span><span style=3D"border-top-width:0px;b=
 order-right-width:0px;border-bottom-width:2px;border-left-width:0px;border-=
 top-style:solid;border-right-style:solid;border-bottom-style:solid;border-l=
 eft-style:solid;border-top-color:rgb(213,15,37);border-right-color:rgb(213,=
 15,37);border-bottom-color:rgb(213,15,37);border-left-color:rgb(213,15,37);=
 padding-top:2px;margin-top:2px;padding-left:3px;padding-right:3px">.com</sp=
 an></div></div>
 </div>
 
 --001a114336c0573c6a053ce1fc76--
Home | Main Index | Thread Index | Old Index