Re: pkg/50188: pkgtools/pkg_install DragonFly 4.3 /usr/lib/libbz2.so.2: error adding symbols

[David Shao <davshao%gmail.com@localhost>]

The following reply was made to PR pkg/50188; it has been noted by GNATS.

From: David Shao <davshao%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/50188: pkgtools/pkg_install DragonFly 4.3 /usr/lib/libbz2.so.2:
 error adding symbols
Date: Sun, 6 Sep 2015 17:00:20 -0700

 The commit below appears to have eliminated all implicit function
 declared warnings.  Thanks.
 
 Module Name:    pkgsrc
 Committed By:   jperkin
 Date:           Sun Sep  6 21:25:19 UTC 2015
 
 Modified Files:
         pkgsrc/security/netpgpverify/files: digest.c sha2.h
 
 Log Message:
 Fix up a few more symbol renames, now -Wimplicit-function-declaration clean.
 
 However on DragonFly 4.3-DEVELOPMENT and presumably various recent
 versions of FreeBSD, building pkgtools/pkg_install still fails with:
 
 cc -lssl -lcrypto -L/usr/pkgsrc/pkgtools/pkg_install/work/libfetch
 -L/usr/pkgsrc/pkgtools/pkg_install/work/netpgpverify
 -L/usr/pkgsrc/pkgtools/pkg_install/work/libnbcompat -L/usr/lib
 -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L../lib -o pkg_add main.o perform.o
 -linstall -larchive -lfetch -lnetpgpverify -lssl -lcrypto -lnbcompat
 /usr/libexec/binutils225/elf/ld.bfd:
 /usr/pkgsrc/pkgtools/pkg_install/work/netpgpverify/libnetpgpverify.a(libverify.o):
 undefined reference to symbol 'BZ2_bzDecompress@@BZ_1.0.6'
 /usr/lib/libbz2.so.2: error adding symbols: DSO missing from command line
 *** Error code 1
 
 Now I don't know if the following patch is the right one:
 
 diff -Nurb pkg_install.orig/Makefile pkg_install/Makefile
 --- pkg_install.orig/Makefile    2015-09-06 16:29:14.875348000 -0700
 +++ pkg_install/Makefile    2015-09-06 16:17:03.144696000 -0700
 @@ -133,10 +133,14 @@
  .if empty(USE_BUILTIN.bzip2:M[yY][eE][sS])
  CPPFLAGS+=    -I${WRKDIR}/bzip2
  LDFLAGS+=    -L${WRKDIR}/bzip2
 +.else
 +LIBS+=        -lbz2
  .endif
  .if empty(USE_BUILTIN.zlib:M[yY][eE][sS])
  CPPFLAGS+=    -I${WRKDIR}/zlib
  LDFLAGS+=    -L${WRKDIR}/zlib
 +.else
 +LIBS+=        -lz
  .endif
  .if empty(USE_BUILTIN.libarchive:M[yY][eE][sS])
  CPPFLAGS+=    -I${WRKDIR}/libarchive/libarchive
 
 But this is I think a case where something has to be done or getting
 pkgsrc installed from source on DragonFly or FreeBSD, and possibly
 other systems for which bzip2 or zlib is part of base, is for all
 practical purposes dead in the water.   How is someone new to pkgsrc
 going to have the faintest idea what to patch?