Re: pkg/50188: pkgtools/pkg_install DragonFly 4.3 /usr/lib/libbz2.so.2: error adding symbols

[David Shao <davshao%gmail.com@localhost>]

The following reply was made to PR pkg/50188; it has been noted by GNATS.

From: David Shao <davshao%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/50188: pkgtools/pkg_install DragonFly 4.3 /usr/lib/libbz2.so.2:
 error adding symbols
Date: Fri, 4 Sep 2015 15:00:47 -0700

 The following patch allows pkgtools/pkg_install to build on DragonFly
 4.3-DEVELOPMENT and seems the simplest:
 
 diff -Nurb pkg_install.orig/Makefile pkg_install/Makefile
 --- pkg_install.orig/Makefile    2015-09-01 05:14:05.000000000 -0700
 +++ pkg_install/Makefile    2015-09-04 14:51:22.887457000 -0700
 @@ -133,10 +133,14 @@
  .if empty(USE_BUILTIN.bzip2:M[yY][eE][sS])
  CPPFLAGS+=    -I${WRKDIR}/bzip2
  LDFLAGS+=    -L${WRKDIR}/bzip2
 +.else
 +LIBS+=        -lbz2
  .endif
  .if empty(USE_BUILTIN.zlib:M[yY][eE][sS])
  CPPFLAGS+=    -I${WRKDIR}/zlib
  LDFLAGS+=    -L${WRKDIR}/zlib
 +.else
 +LIBS+=        -lz
  .endif
  .if empty(USE_BUILTIN.libarchive:M[yY][eE][sS])
  CPPFLAGS+=    -I${WRKDIR}/libarchive/libarchive
 
 This is a sample from files/add/Makefile.in:
 
 CC=        @CC@
 CCLD=        $(CC)
 CPPFLAGS=    @CPPFLAGS@ -I. -I$(srcdir) -I../lib
 DEFS=        @DEFS@ -DOPSYS_NAME=\"$(OPSYS)\"
 -DMACHINE_ARCH=\"$(MACHINE_ARCH)\" -DBINDIR=\"$(sbindir)\"
 CFLAGS=        @CFLAGS@
 LDFLAGS=    @LDFLAGS@ -L../lib
 
 SSL_SUPPORT=    @ssl_support@
 
 LIBS=        -linstall -larchive -lfetch -lnetpgpverify
 .if !empty(SSL_SUPPORT)
 LIBS+=        -lssl -lcrypto
 .endif
 LIBS+=        @LIBS@
 
 
 In my opinion the following may still need to be addressed:
 
 checking md5.h usability... yes
 checking md5.h presence... yes
 checking for md5.h... yes
 checking for MD5Init in md5.h... yes
 checking for md5.h... (cached) yes
 checking rmd160.h usability... yes
 checking rmd160.h presence... yes
 checking for rmd160.h... yes
 checking sha1.h usability... no
 checking sha1.h presence... no
 checking for sha1.h... no
 checking sha2.h usability... no
 checking sha2.h presence... no
 checking for sha2.h... no
 checking for MD5File... no
 checking for RMD160File... no
 checking for SHA1File... no
 checking for SHA512_File... no
 ...
 cc -g -I/usr/include -D_LARGEFILE_SOURCE -D_LARGE_FILES
 -D_FILE_OFFSET_BITS=64 -DDEF_UMASK=0022
 -I/usr/pkgsrc/pkgtools/pkg_install/work/libfetch
 -I/usr/pkgsrc/pkgtools/pkg_install/work -DHAVE_NBCOMPAT_H=1
 -I/usr/pkgsrc/pkgtools/pkg_install/work/libnbcompat -I/usr/include -c
 digest.c
 digest.c: In function 'digest_init':
 digest.c:131:3: warning: implicit declaration of function 'RMD160Init'
 [-Wimplicit-function-declaration]
    RMD160Init(&hash->u.rmd160ctx);
    ^
 digest.c: In function 'digest_update':
 digest.c:215:3: warning: implicit declaration of function
 'RMD160Update' [-Wimplicit-function-declaration]
    RMD160Update(hash->ctx, data, (unsigned)length);
    ^
 digest.c: In function 'digest_final':
 digest.c:247:3: warning: implicit declaration of function
 'RMD160Final' [-Wimplicit-function-declaration]
    RMD160Final(out, hash->ctx);
    ^
 digest.c:253:3: warning: implicit declaration of function
 'netpgpv_SHA512_Final' [-Wimplicit-function-declaration]
    netpgpv_SHA512_Final(out, hash->ctx);
    ^