Re: pkg/49062: mail/thunderbird fails to build on NetBSD-6.1.4/amd64

[Greg Oster <oster%cs.usask.ca@localhost>]

The following reply was made to PR pkg/49062; it has been noted by GNATS.

From: Greg Oster <oster%cs.usask.ca@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/49062: mail/thunderbird fails to build on
 NetBSD-6.1.4/amd64
Date: Fri, 8 Aug 2014 09:44:18 -0600

 On Fri,  8 Aug 2014 05:40:01 +0000 (UTC)
 David Holland <dholland-pbugs%netbsd.org@localhost> wrote:
 
 > The following reply was made to PR pkg/49062; it has been noted by
 > GNATS.
 > 
 > From: David Holland <dholland-pbugs%netbsd.org@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: pkg/49062: mail/thunderbird fails to build on
 > NetBSD-6.1.4/amd64 Date: Fri, 8 Aug 2014 05:38:13 +0000
 > 
 >  On Fri, Aug 01, 2014 at 07:30:00PM +0000, oster%netbsd.org@localhost wrote:
 >   > => Applying pkgsrc patches for thunderbird-31.0
 >   > No such line 315 in input file, ignoring
 >  
 >  Can you try this with PKG_DEVELOPER set so you can see which patch it
 >  comes from? None of the patches seem to contain a reference to line
 > 315. 
 >  (I don't have the distfile to try it myself)
 
 That error comes from here:
 
 => Applying pkgsrc
 patch 
/usr/pkgsrc/mail/thunderbird/patches/patch-mozilla_ipc_chromium_src_base_process__util.h
 Hmm...  Looks like a unified diff to me... The text leading up to this
 was: --------------------------
 |$NetBSD: patch-mozilla_ipc_chromium_src_base_process__util.h,v 1.5
 2013/11/12 20:50:51 ryoon Exp $ |
 |--- mozilla/ipc/chromium/src/base/process_util.h.orig  2013-10-23
 22:09:00.000000000 +0000 |+++
 mozilla/ipc/chromium/src/base/process_util.h --------------------------
 Patching file mozilla/ipc/chromium/src/base/process_util.h using Plan
 A... Hunk #1 succeeded at 13.
 Hunk #2 succeeded at 32.
 No such line 315 in input file, ignoring
 Hunk #3 succeeded at 252 (offset -67 lines).
 done
 
 which is this part of the patch:
 
 @@ -316,7 +319,7 @@ class NamedProcessIterator {
  #if defined(OS_WIN)
    HANDLE snapshot_;
    bool started_iteration_;
 -#elif defined(OS_LINUX) || defined(__GLIBC__)
 +#elif defined(OS_LINUX) || defined(__GLIBC__) || defined(OS_SOLARIS)
    DIR *procfs_dir_;
  #elif defined(OS_BSD)
    std::vector<ProcessEntry> content;
 
 But that part of the file occurs around line 255, and really isn't
 related to the NetBSD build... 
 
 A bit more digging reveals that in:
 
 
/usr/pkgsrc/mail/thunderbird/work.mickey/comm-esr31/mail/components/shell/nsMailGNOMEIntegration.cpp
 
 we find at line 43:
 
 struct AppTypeAssociation {
   uint16_t type;
   const char * const *protocols;
   unsigned int protocolsLength;
   const char *mimeType;
   const char *extensions;
 };
 
 If I change protocolsLength to size_t, then thunderbird builds, and
 seems to work fine...
 
 Later...
 
 Greg Oster