Re: pkg/48776: www/firefox 29.0 cannot convert 'float**' to 'mozilla::AudioDataValue** {aka short int**}'

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

The following reply was made to PR pkg/48776; it has been noted by GNATS.

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost, davshao%gmail.com@localhost
Cc: 
Subject: Re: pkg/48776: www/firefox 29.0 cannot convert 'float**' to
 'mozilla::AudioDataValue** {aka short int**}'
Date: Fri, 02 May 2014 13:58:24 +0900 (JST)

 Hi,
 
 From: David Shao <davshao%gmail.com@localhost>, Date: Fri,  2 May 2014 
03:45:01 +0000 (UTC)
 
 > The following reply was made to PR pkg/48776; it has been noted by GNATS.
 > 
 > From: David Shao <davshao%gmail.com@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: pkg/48776: www/firefox 29.0 cannot convert 'float**' to
 >  'mozilla::AudioDataValue** {aka short int**}'
 > Date: Thu, 1 May 2014 20:42:10 -0700
 > 
 >  The following trivial patch allows www/firefox 29.0 to build and be
 >  replaced on DragonFly 3.7-DEVELOPMENT x86_64.  I am using Firefox 29.0
 >  right now to compose this reply on the previously affected machine.
 >  
 >  The documentation indicates that
 >  
 >  MOZ_SAMPLE_TYPE_S16
 >  
 >  should probably not be set on any desktop machine, only on Android.
 >  Hopefully some FreeBSD and some OpenBSD user of current cvs pkgsrc can
 >  indicate whether the same patch proposed below for DragonFly should be
 >  used for these OSes as well.
 
 Thank you very much.
 Now I am rebuilding pkgsrc test environments.
 After rebuild, I will check OpenBSD and FreeBSD build.
 
 >  diff -Nur firefox.orig/distinfo firefox/distinfo
 >  --- firefox.orig/distinfo    2014-04-30 08:07:17.000000000 -0700
 >  +++ firefox/distinfo    2014-05-01 17:35:25.000000000 -0700
 >  @@ -3,7 +3,7 @@
 >   SHA1 (firefox-29.0.source.tar.bz2) = 
 > db8fa9a4863bd7427115adec01b7db0e494dffa6
 >   RMD160 (firefox-29.0.source.tar.bz2) = 
 > f98208b799067e6fb688713035f32cce0d32f84b
 >   Size (firefox-29.0.source.tar.bz2) = 143163777 bytes
 >  -SHA1 (patch-aa) = 156ae389f81c19e8dbd776ef4b154b453ca5f1fe
 >  +SHA1 (patch-aa) = 14c2de752a5fa09e7ba959a8c5f17a180883bb4a
 >   SHA1 (patch-ak) = 971ddb1f12b14bcee604c9d7e72da5e7bf47d9be
 >   SHA1 (patch-al) = cca5df21d018bb9f428ad26d00718f33afe88ec5
 >   SHA1 (patch-ao) = ca7e6723a10b9f6e3306cd12557e1856727edee9
 >  diff -Nur firefox.orig/patches/patch-aa firefox/patches/patch-aa
 >  --- firefox.orig/patches/patch-aa    2014-04-30 08:07:18.000000000 -0700
 >  +++ firefox/patches/patch-aa    2014-05-01 17:35:08.000000000 -0700
 >  @@ -203,7 +203,7 @@
 >    dnl backends for those platforms don't support floats.
 >   -if test "$OS_TARGET" = "Android"; then
 >   +case "$OS_TARGET" in
 >  -+Android|DragonFly|FreeBSD|OpenBSD)
 >  ++Android|FreeBSD|OpenBSD)
 >        MOZ_SAMPLE_TYPE_S16=1
 >        AC_DEFINE(MOZ_SAMPLE_TYPE_S16)
 >        AC_SUBST(MOZ_SAMPLE_TYPE_S16)
 >  
 
 --
 Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3