Re: pkg/45195 (security/heimdal does misses symbols (_kdc_db_fetch, _kdc_free_ent))

[Alex Hornung <ahornung%gmail.com@localhost>]

The following reply was made to PR pkg/45195; it has been noted by GNATS.

From: Alex Hornung <ahornung%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: dfly-pkg-people%netbsd.org@localhost, 
dragonfly-pkg-people%netbsd.org@localhost, 
        pkgsrc-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
gls%netbsd.org@localhost
Subject: Re: pkg/45195 (security/heimdal does misses symbols (_kdc_db_fetch, 
_kdc_free_ent))
Date: Sun, 31 Jul 2011 20:19:43 +0100

 --bcaec5431eec9aeeb304a9626545
 Content-Type: text/plain; charset=ISO-8859-1
 
 Well, this is actually an upstream issue. The symbols are being forced
 to local visibility by the linker script even though they are used
 from outside. I've also raised this issue upstream.
 
 The attached patch fixes building on DragonFly; please commit it;
 patch is at http://leaf.dragonflybsd.org/~alexh/heimdal-ldscript.patch,
 and attached to this message.
 
 Cheers,
 Alex
 
 Upstream bug description:
 The symbols _kdc_db_fetch and _kdc_free_ent are also used externally
 from libkdc, and not just internally. They are referenced from
 kdc/digest-service. As such, the linker script cannot force those
 symbols to be local, otherwise more picky linkers will fail to find
 the symbols. The attached patch adds the two symbols to global
 visibility, so that they can be referenced from kdc/digest-service.
 
 This also fixes build on DragonFly.
 
 --bcaec5431eec9aeeb304a9626545
 Content-Type: text/x-patch; charset=US-ASCII; name="heimdal-ldscript.patch"
 Content-Disposition: attachment; filename="heimdal-ldscript.patch"
 Content-Transfer-Encoding: base64
 X-Attachment-Id: f_gqse8tyy0
 
 ZGlmZiAtLWdpdCBhL3NlY3VyaXR5L2hlaW1kYWwvZGlzdGluZm8gYi9zZWN1cml0eS9oZWltZGFs
 L2Rpc3RpbmZvCmluZGV4IGNlYTY1MjAuLmNkM2ZkYTEgMTAwNjQ0Ci0tLSBhL3NlY3VyaXR5L2hl
 aW1kYWwvZGlzdGluZm8KKysrIGIvc2VjdXJpdHkvaGVpbWRhbC9kaXN0aW5mbwpAQCAtMyw2ICsz
 LDcgQEAgJE5ldEJTRDogZGlzdGluZm8sdiAxLjI3IDIwMTEvMDcvMDggMDk6NDk6MjEgYWRhbSBF
 eHAgJAogU0hBMSAoaGVpbWRhbC0xLjQudGFyLmd6KSA9IGI0Yzg3NmRmMzYzN2ExMWRlZWE3MmY4
 N2E2ZTU0ZjZjYWY1MDE2NzkKIFJNRDE2MCAoaGVpbWRhbC0xLjQudGFyLmd6KSA9IDA1NTI4OGYx
 YWIzNzc4MWYxNTMzMjk5YmRmZjliMGQxZTI2NGQ0NzAKIFNpemUgKGhlaW1kYWwtMS40LnRhci5n
 eikgPSA2MDk1Mzc3IGJ5dGVzCitTSEExIChwYXRjaC1hYSkgPSA4M2JkOTkxYzhkNDY3YTRkOWVj
 YTgxMWFlNjRkNTNmYjdiYmRmOTlkCiBTSEExIChwYXRjaC1hZCkgPSAzN2MyYTdjZGM0ZGJhNjk1
 YTg0MDU3YjQwYWFlM2M1YTk3MWNiNTQ2CiBTSEExIChwYXRjaC1hbCkgPSAwMjJkNWYzNzIzYmQx
 ZGI3ZmU1ZTkyZWVhNWQwMTA2ODUxYTVkNDI0CiBTSEExIChwYXRjaC1hcikgPSAwYTNlN2JiZDNj
 YjA0ZGViMGY2NzcyYWZkOWE2YjZiNTM1MzQ2M2QzCmRpZmYgLS1naXQgYS9zZWN1cml0eS9oZWlt
 ZGFsL3BhdGNoZXMvcGF0Y2gtYWEgYi9zZWN1cml0eS9oZWltZGFsL3BhdGNoZXMvcGF0Y2gtYWEK
 bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZTJlMmYzNgotLS0gL2Rldi9udWxs
 CisrKyBiL3NlY3VyaXR5L2hlaW1kYWwvcGF0Y2hlcy9wYXRjaC1hYQpAQCAtMCwwICsxLDExIEBA
 CistLS0ga2RjL3ZlcnNpb24tc2NyaXB0Lm1hcC5vcmlnCTIwMTEtMDctMzEgMjA6MDM6MDYuMDMw
 MTk1MDAwICswMTAwCisrKysga2RjL3ZlcnNpb24tc2NyaXB0Lm1hcAkyMDExLTA3LTMxIDIwOjA0
 OjAzLjMxMDI3NTAwMCArMDEwMAorQEAgLTIsNiArMiw4IEBACisgCisgSEVJTURBTF9LRENfMS4w
 IHsKKyAJZ2xvYmFsOgorKwkJX2tkY19kYl9mZXRjaDsKKysJCV9rZGNfZnJlZV9lbnQ7CisgCQlr
 ZGNfbG9nOworIAkJa2RjX2xvZ19tc2c7CisgCQlrZGNfbG9nX21zZ192YTsK
 --bcaec5431eec9aeeb304a9626545--