Re: pkg/45195 (security/heimdal does misses symbols (_kdc_db_fetch, _kdc_free_ent))

[Alex Hornung <ahornung%gmail.com@localhost>]

Well, this is actually an upstream issue. The symbols are being forced
to local visibility by the linker script even though they are used
from outside. I've also raised this issue upstream.

The attached patch fixes building on DragonFly; please commit it;
patch is at http://leaf.dragonflybsd.org/~alexh/heimdal-ldscript.patch,
and attached to this message.

Cheers,
Alex

Upstream bug description:
The symbols _kdc_db_fetch and _kdc_free_ent are also used externally
from libkdc, and not just internally. They are referenced from
kdc/digest-service. As such, the linker script cannot force those
symbols to be local, otherwise more picky linkers will fail to find
the symbols. The attached patch adds the two symbols to global
visibility, so that they can be referenced from kdc/digest-service.

This also fixes build on DragonFly.

diff --git a/security/heimdal/distinfo b/security/heimdal/distinfo
index cea6520..cd3fda1 100644
--- a/security/heimdal/distinfo
+++ b/security/heimdal/distinfo
@@ -3,6 +3,7 @@ $NetBSD: distinfo,v 1.27 2011/07/08 09:49:21 adam Exp $
 SHA1 (heimdal-1.4.tar.gz) = b4c876df3637a11deea72f87a6e54f6caf501679
 RMD160 (heimdal-1.4.tar.gz) = 055288f1ab37781f1533299bdff9b0d1e264d470
 Size (heimdal-1.4.tar.gz) = 6095377 bytes
+SHA1 (patch-aa) = 83bd991c8d467a4d9eca811ae64d53fb7bbdf99d
 SHA1 (patch-ad) = 37c2a7cdc4dba695a84057b40aae3c5a971cb546
 SHA1 (patch-al) = 022d5f3723bd1db7fe5e92eea5d0106851a5d424
 SHA1 (patch-ar) = 0a3e7bbd3cb04deb0f6772afd9a6b6b5353463d3
diff --git a/security/heimdal/patches/patch-aa 
b/security/heimdal/patches/patch-aa
new file mode 100644
index 0000000..e2e2f36
--- /dev/null
+++ b/security/heimdal/patches/patch-aa
@@ -0,0 +1,11 @@
+--- kdc/version-script.map.orig        2011-07-31 20:03:06.030195000 +0100
++++ kdc/version-script.map     2011-07-31 20:04:03.310275000 +0100
+@@ -2,6 +2,8 @@
+ 
+ HEIMDAL_KDC_1.0 {
+       global:
++              _kdc_db_fetch;
++              _kdc_free_ent;
+               kdc_log;
+               kdc_log_msg;
+               kdc_log_msg_va;