pkg/45012: lang/clisp build broken on systems where /bin/sh == dash (e.g. Ubuntu)

[maw%dont.beevil.org@localhost]

>Number:         45012
>Category:       pkg
>Synopsis:       lang/clisp build broken on systems where /bin/sh == dash (e.g. 
>Ubuntu)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 01 04:05:00 +0000 2011
>Originator:     Michael Wildpaner
>Release:        pkgsrc-2011Q1 and HEAD
>Organization:
>Environment:
Linux myhostname 2.6.32-31-server #61-Ubuntu SMP Fri Apr 8 19:44:42 UTC 2011 
x86_64 GNU/Linux
>Description:
Ubuntu uses dash as /bin/sh. In dash, the shell test expression -nt evaluates 
to 1==false if the second operand doesn't exist (as compared to bash where it 
evaluate to 0==true).

This breaks module building for package lang/clisp (per-module Makefile in e.g. 
src/i18n is never generated and recursive make invocation with target 
clisp-module fails).
>How-To-Repeat:
Build lang/clisp on a system with /bin/sh == dash, e.g. recent Ubuntu.


>Fix:
This is ultimately a bug in the clisp build system, but until that's fixed 
upstream:

-- /dev/null   2011-05-08 17:10:55.626731700 +0200
+++ lang/clisp/patches/patch-ad 2011-06-01 05:55:20.442482943 +0200
@@ -0,0 +1,13 @@
+$NetBSD$
+
+--- src/makemake.in.orig       2011-06-01 03:53:29.283733000 +0000
++++ src/makemake.in
+@@ -3301,7 +3301,7 @@ echotab "m=\`cd ${MODULESDIR_}\$@; pwd\`
+ if [ "@TEST_NT@" = no ]; then # re-making a module requires rm -rf module
+   newer(){ echo 'test -f $$m/'$1' -a '"'!'"' -f $@/'$2; }
+ else # re-making a module just works
+-  newer(){ echo 'test -f $$m/'$1' -a $$m/'$1' -nt $@/'$2; }
++  newer(){ echo 'test -f $$m/'$1' -a \( ! -f $@/'$2' -o $$m/'$1' -nt $@/'$2' 
\)'; }
+ fi
+ # srcdir has to be passed to ./configure because it must be able to find
+ # src/build-aux/install-sh _AND_ also its own sources, thus we must