pkg/44201: editors/leafpad PLIST problem (well, not really) (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         44201
>Category:       pkg
>Synopsis:       editors/leafpad PLIST problem (well, not really) (+FIX)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 08 03:30:00 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 5.0    (pkgsrc current (head) 2019-12-08)
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1 NetBSD 5.1 (JADE-1.12-20101117) #5: Wed 
Nov 17 05:30:55 ICT 2010 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/5.1/kernels/i386/JADE i386
Architecture: i386
Machine: i386
>Description:
        editors/leafpad apparently used the gnome hicolor theme stuff,
        but doesn't include the magic bl3 file to make that work
        correctly, which ic detected as a PLIST problem by the package
        build process if PKG_DEVELOPER is set.

>How-To-Repeat:
        I use pkg_comp with NetBSD 5.0 release sets, and libkver installed.
        The only real relevance of that is that pkg_comp defaults
        PKG_DEVELOPER=yes  (all developers should use that anyway...)
        and I start in an empty sandbox, so the hicolor theme file will not
        be installed already unless something in the package being built
        (or a dependency) demands it.

        In that environment, I see ...

=> Registering installation for leafpad-0.8.17nb3
leafpad-0.8.17nb3 requires installed package desktop-file-utils-0.15
leafpad-0.8.17nb3 requires installed package gtk2+-2.22.1
=> Checking file-check results for leafpad-0.8.17nb3
ERROR: ************************************************************
ERROR: The following files are in /usr/pkg but not in the PLIST:
ERROR:         /usr/pkg/share/icons/hicolor/icon-theme.cache
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/editors/leafpad
*** Error code 1

Stop.

>Fix:
        This is a "well known" problem I believe.   The patch below is
        the standard fix, I think.   I included a revbump, as I think
        I recall that the hicolor-icon-theme bl3 file changes the affected
        binary package slightly - and for builds without PKG_DEVELOPER
        set, a binary package would have been produced from this pkgsrc
        package the way it was.  If the revbump isn't needed (that is, if
        the added bl3 file is effectively doing no more than excluding the
        cache file from the package) then feel free to ignore that part.

        This patch applies in pkgsrc/editors/leafpad

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/editors/leafpad/Makefile,v
retrieving revision 1.22
diff -u -r1.22 Makefile
--- Makefile    15 Nov 2010 22:56:52 -0000      1.22
+++ Makefile    8 Dec 2010 03:13:52 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.22 2010/11/15 22:56:52 abs Exp $
 
 DISTNAME=      leafpad-0.8.17
-PKGREVISION=   3
+PKGREVISION=   4
 CATEGORIES=    editors gnome
 MASTER_SITES=  http://savannah.nongnu.org/download/leafpad/
 
@@ -17,6 +17,7 @@
 
 .include "../../converters/libiconv/buildlink3.mk"
 .include "../../devel/gettext-lib/buildlink3.mk"
+.include "../../graphics/hicolor-icon-theme/buildlink3.mk"
 .include "../../sysutils/desktop-file-utils/desktopdb.mk"
 .include "../../x11/gtk2/buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"