pkg/43797: devel/atf doesn't honor NOGCCERROR

[alnsn%yandex.ru@localhost]

>Number:         43797
>Category:       pkg
>Synopsis:       devel/atf doesn't honor NOGCCERROR
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 24 09:10:00 +0000 2010
>Originator:     Alexander Nasonov
>Release:        Linux
>Organization:
N/A
>Environment:
Linux boy 2.6.18-128.el5 #1 SMP Wed Jan 21 10:41:14 EST 2009 x86_64 x86_64 
x86_64 GNU/Linux
>Description:
devel/aft compilation fails after emitting a bunch of warnings. It does so even 
if I define NOGCCERROR=1 in mk.conf:

...
g++ -DHAVE_CONFIG_H -I.      -Wno-error -Wno-format -fno-builtin  -g -Wall 
-Wcast-qual -Werror -Wextra -Wno-unused-parameter -Wpointer-arith 
-Wredundant-decls -Wreturn-type -Wshadow -Wsign-compare -Wswitch 
-Wwrite-strings -D_FORTIFY_SOURCE=2 -Wabi -Wctor-dtor-privacy -Wno-deprecated 
-Wno-non-template-friend -Wno-pmf-conversions -Wnon-virtual-dtor 
-Woverloaded-virtual -Wreorder -Wsign-promo -Wsynth -MT atf-report/reader.o -MD 
-MP -MF $depbase.Tpo -c -o atf-report/reader.o atf-report/reader.cpp && mv -f 
$depbase.Tpo $depbase.Po
--- atf-check/atf-check.o ---
cc1plus: warnings being treated as errors
atf-check/atf-check.cpp:600: warning: 'atf_check' has a field 
'atf_check::m_status_checks' whose type uses the anonymous namespace
atf-check/atf-check.cpp:600: warning: 'atf_check' has a field 
'atf_check::m_stdout_checks' whose type uses the anonymous namespace
atf-check/atf-check.cpp:600: warning: 'atf_check' has a field 
'atf_check::m_stderr_checks' whose type uses the anonymous namespace
...

I'm using gcc 4.1.2:
$ /usr/bin/gcc -v
Using built-in specs.
Target: x86_64-redhat-linux
Configured with: ../configure --prefix=/usr --mandir=/usr/share/man 
--infodir=/usr/share/info --enable-shared --enable-threads=posix 
--enable-checking=release --with-system-zlib --enable-__cxa_atexit 
--disable-libunwind-exceptions --enable-libgcj-multifile 
--enable-languages=c,c++,objc,obj-c++,java,fortran,ada --enable-java-awt=gtk 
--disable-dssi --enable-plugin 
--with-java-home=/usr/lib/jvm/java-1.4.2-gcj-1.4.2.0/jre --with-cpu=generic 
--host=x86_64-redhat-linux
Thread model: posix
gcc version 4.1.2 20080704 (Red Hat 4.1.2-44)

>How-To-Repeat:
cd devel/atf
bmake package-install
>Fix: