Re: pkg/43387: XFCE update: 4.6.2

[dieter roelants <dieter.NetBSD%pandora.be@localhost>]

The following reply was made to PR pkg/43387; it has been noted by GNATS.

From: dieter roelants <dieter.NetBSD%pandora.be@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/43387: XFCE update: 4.6.2
Date: Mon, 31 May 2010 14:45:59 +0200

 On Mon, 31 May 2010 08:35:02 +0000 (UTC)
 "OBATA Akio" <obache%netbsd.org@localhost> wrote:
 
 >  > Explicitly set XFCE4_VERSION for packages that stayed at 4.6.1.
 >  
 >  What does it mean? still not updated yet? or not a part of xfce4?
 
 Not part of the 4.6.2 release.
 
 >  > Index: meta-pkgs/xfce4/Makefile
 >  
 >  Incidentally, OK to convert from "buildlink to depending packages" to
 >  simple "DEPENDS"?
 >  I feel this is meta-pkg, no need to build, so no need to BUILDlink
 
 That makes sense...
 
 >  > Index: meta-pkgs/xfce4/Makefile.common
 >  
 >  Why MASTER_SITES still point to 4.6.1?
 
 Because I forgot to update it...
 
 >  I feel that individual packages should not set its standalone version to 
 > XFCE4_VERSION,
 >  and ${XFCE4_VERSION} should be used as subdir of MASTER_SITES.
 
 I agree about the second, but why would you not override XFCE4_VERSION?
 It would automatically provide a correct MASTER_SITES for the 4.6.1
 packages. (The 4.6.1 distfiles were not replicated in the 4.6.2
 directory.)
 
 Thanks for looking at this.
 
 dieter