pkg/42200: net/quagga-devel needs gawk (NetBSD 4.0) (+FIX)

[kre%munnari.OZ.AU@localhost]

>Number:         42200
>Category:       pkg
>Synopsis:       net/quagga-devel needs gawk (NetBSD 4.0)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 19 14:20:01 +0000 2009
>Originator:     Robert Elz
>Release:        NetBSD 4.0  pkgsrc current 2009-10-19
>Organization:
        Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 4.0_STABLE NetBSD 4.0_STABLE 
(JADE-1.696-20080517) #9: Fri May 23 18:55:13 ICT 2008 
kre%jade.coe.psu.ac.th@localhost:/usr/obj/4/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
        After the recent upgrade of devel/quagga from quagga-0.99.12nb1
        to quagga-0.99.15 the build fails on NetBSD 4.0 (perhaps other
        NetBSD, I don't know).

>How-To-Repeat:
        I use pkg_comp with NetBSD 4.0 sets installed, and libkver
        to simuulate a fairly pure NetBSD 4.0 release environment.
        (No x* sets, I use pkgsrc modular xorg, but that's irrelevant here).

        Building net/quagga-devel results in ...

checking for gawk... /usr/bin/awk
checking whether make sets $(MAKE)... yes
checking for gawk... not-in-PATH
configure: error: GNU awk is required for lib/memtype.h made by memtypes.awk.
BSD awk complains: awk: gensub doesn't support backreferences (subst "\1") 
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/net/quagga-devel
*** Error code 1

Stop.

        Note that even the patch below, I saw a bunch of weird
        looking errors scroll past while the build was proceeding,
        but they didn't seem to bother anything, so I just ignored
        them.   They were ...

./extract.pl ../bgpd/*.c ../isisd/*.c ../ospfd/*.c ../ospf6d/*.c ../ripd/*.c 
../ripngd/*.c ../lib/keychain.c ../lib/routemap.c ../lib/filter.c 
../lib/plist.c ../lib/distribute.c ../lib/if_rmap.c ../lib/vty.c 
../zebra/debug.c ../zebra/interface.c ../zebra/irdp_interface.c 
../zebra/rtadv.c ../zebra/zebra_vty.c ../zebra/zserv.c ../zebra/router-id.c 
../zebra/zebra_routemap.c > vtysh_cmd.c
../isisd/isis_dlpi.c:29:21: error: stropts.h: No such file or directory
../isisd/isis_dlpi.c:31:22: error: sys/dlpi.h: No such file or directory
../isisd/isis_dlpi.c:32:23: error: sys/pfmod.h: No such file or directory
../isisd/isis_pfpacket.c:24:49: error: net/ethernet.h: No such file or directory
../isisd/isis_pfpacket.c:25:30: error: netpacket/packet.h: No such file or 
directory

>Fix:
        The appended patch (truly an easy fix...) corrects the awk/gawk
        issue for me.

        It may be that the addition of gawk to USE_TOOLS should be
        conditional on NetBSD version 4.* - I don't know if the needed
        functionality has grown into NetBSD awk in 5.0 and later.

--- Makefile.ORIG       2009-10-18 05:41:12.000000000 +0700
+++ Makefile    2009-10-19 21:05:06.000000000 +0700
@@ -12,7 +12,7 @@
 .include "../../mk/bsd.prefs.mk"
 
 GNU_CONFIGURE=         YES
-USE_TOOLS+=            gmake perl
+USE_TOOLS+=            gmake perl gawk
 USE_LIBTOOL=           YES
 
 PKG_SYSCONFSUBDIR?=    zebra