Re: pkg/41940 (devel/cflow file-check test failure - uninstalled locale files (NetBSD 4.0))

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR pkg/41940; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/41940 (devel/cflow file-check test failure - uninstalled 
locale files (NetBSD 4.0)) 
Date: Mon, 19 Oct 2009 20:52:23 +0700

     Date:        Tue,  1 Sep 2009 13:00:06 +0000 (UTC)
     From:        Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
     Message-ID:  <20090901130006.EFAA963BC1D%www.NetBSD.org@localhost>
 
   |  Kill that please. NetBSD doesn't ship a GNU libintl and testing for that
   |  is just wrong.
 
 Since no-one has done anything about that since that message was
 sent, and as Hasso recently returned this PR to limbo (aka pkg_manager)
 I thought I'd see if I could work out how to make that happen.
 
 The patch below updates devel/cflow from 1.3nb1 to 1.3nb2 and fixes
 the build of the package following Joerg's suggestion - the way i did
 that might be considered a little perverse, and I have no idea if
 this will work correctly if used on a system that happens to have
 GNU libintl in its base - like perhaps a linux system) but it does
 correct the problem for me, it allows the package to be built, and
 with the language (message) files included (unlike version 1.3
 where they were just absent on NetBSD, and 1.3nb1 where the PLIST
 said they should be there, but they weren't).
 
 This should apply in the pkgsrc/devel/cflow directory, though you
 will probably need to "mkdir patches" manually.   I have no idea
 if the patch-aa file is supposed to have a $NetBSD$ Tag header in it
 or not, so I just left that out...
 
 kre
 
 diff -r -u --unidirectional-new-file ../cflow/Makefile ./Makefile
 --- ../cflow/Makefile  2009-08-26 15:37:41.000000000 +0700
 +++ ./Makefile 2009-10-19 20:41:38.000000000 +0700
 @@ -1,7 +1,7 @@
  # $NetBSD: Makefile,v 1.8 2009/08/25 20:09:18 hasso Exp $
  
  DISTNAME=     cflow-1.3
 -PKGREVISION=  1
 +PKGREVISION=  2
  CATEGORIES=   devel
  MASTER_SITES= ${MASTER_SITE_GNU:=cflow/}
  
 diff -r -u --unidirectional-new-file ../cflow/distinfo ./distinfo
 --- ../cflow/distinfo  2009-08-23 05:47:23.000000000 +0700
 +++ ./distinfo 2009-10-19 20:39:01.000000000 +0700
 @@ -3,3 +3,4 @@
  SHA1 (cflow-1.3.tar.gz) = 8cc32e7e75f6b1ecbd90d7699cdd859d9419c28c
  RMD160 (cflow-1.3.tar.gz) = 90c7652590a85b762034151b5f9ed94c6f4b4cb6
  Size (cflow-1.3.tar.gz) = 759691 bytes
 +SHA1 (patch-aa) = 4787d81ed91187757a8626562d7146e69f694138
 diff -r -u --unidirectional-new-file ../cflow/patches/patch-aa 
./patches/patch-aa
 --- ../cflow/patches/patch-aa  1970-01-01 07:00:00.000000000 +0700
 +++ ./patches/patch-aa 2009-10-19 20:38:46.000000000 +0700
 @@ -0,0 +1,10 @@
 +--- configure.was     2009-10-19 13:29:28.000000000 +0000
 ++++ configure 2009-10-19 13:36:34.000000000 +0000
 +@@ -2158,7 +2158,6 @@
 + ac_header_list="$ac_header_list sysexits.h"
 + ac_header_list="$ac_header_list unistd.h"
 + ac_func_list="$ac_func_list vasnprintf"
 +-gt_needs="$gt_needs need-formatstring-macros"
 + # Check that the precious variables saved in the cache have kept the same
 + # value.
 + ac_cache_corrupted=false