Re: pkg/39902: openssh package can't create sshd userid - missing full path name for shell

[Adrian Portelli <adrianp%stindustries.net@localhost>]

The following reply was made to PR pkg/39902; it has been noted by GNATS.

From: Adrian Portelli <adrianp%stindustries.net@localhost>
To: OBATA Akio <obache%NetBSD.org@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, ahoka%NetBSD.org@localhost
Subject: Re: pkg/39902: openssh package can't create sshd userid - missing
 full path name for shell
Date: Wed, 12 Nov 2008 21:39:20 +0000

 OBATA Akio wrote:
 > This problem is appeard after ${TOOLS_PLATFORM.false} is replaced with
 > shell builtin.
 > in mk/tools/tools.SunOS.mk rev1.29.
 > For OpenSolaris, replaced with GNU false in rev1.30 to avoid this issue.
 > 
 > How about replace following line in mk/platform/SunOS.mk?
 > (and tools.SunOS.mk back to rev1.29)?
 > 
 > < NOLOGIN?=    ${FALSE}
 >> NOLOGIN?=    /usr/bin/false
 > 
 
 Sure, sounds logical to me.  On OpenSolairs it happened to be in
 /usr/gnu/bin/false, searching a little harder now it's also in
 /usr/bin/.  I'd suggest the following change:
 
 Index: mk/tools/tools.SunOS.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/mk/tools/tools.SunOS.mk,v
 retrieving revision 1.30
 diff -u -r1.30 tools.SunOS.mk
 --- mk/tools/tools.SunOS.mk    11 Sep 2008 23:00:31 -0000      1.30
 +++ mk/tools/tools.SunOS.mk    12 Nov 2008 21:36:53 -0000
 @@ -44,11 +44,7 @@
  TOOLS_PLATFORM.egrep?=                /usr/xpg4/bin/grep -E
  TOOLS_PLATFORM.env?=          /usr/bin/env
  TOOLS_PLATFORM.expr?=         /usr/xpg4/bin/expr
 -.if exists(/usr/gnu/bin/false)        # if we are using OpenSolaris
 -TOOLS_PLATFORM.false?=                /usr/gnu/bin/false
 -.else
 -TOOLS_PLATFORM.false?=                false                   # shell builtin
 -.endif
 +TOOLS_PLATFORM.false?=                /usr/bin/false
  TOOLS_PLATFORM.fgrep?=                /usr/xpg4/bin/fgrep
  TOOLS_PLATFORM.file?=         /usr/bin/file
  TOOLS_PLATFORM.find?=         /usr/bin/find
 
 Would mk/platform/SunOS.mk then pick up ${FALSE} correctly ?
 
 adrian.