pkg/39876: xpkgwedge fails to patch on IRIX

[srcshelton%gmail.com@localhost]

>Number:         39876
>Category:       pkg
>Synopsis:       xpkgwedge fails to patch on IRIX
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 07 11:05:00 +0000 2008
>Originator:     Stuart Shelton
>Release:        pkgsrc latest from CVS
>Organization:
>Environment:
IRIX 6.5.30f; MIPSpro Compilers, Version 7.4.4m
>Description:

xpkgwedge fails with:

===> su-do-clean [xpkgwedge-1.16] ===> Cleaning for xpkgwedge-1.16
===> _flavor-check-vulnerable [xpkgwedge-1.16] ===> Checking for 
vulnerabilities in xpkgwedge-1.16
===> depends-message [xpkgwedge-1.16] ===> Installing dependencies for 
xpkgwedge-1.16
=> Build dependency gmake>=3.81: found gmake-3.81
=> Build dependency patch>=2.2: found patch-2.5.4nb2
=> Build dependency x11-links>=0.40: found x11-links-0.40
===> tools-message [xpkgwedge-1.16] ===> Overriding tools for xpkgwedge-1.16
===> extract-message [xpkgwedge-1.16] ===> Extracting for xpkgwedge-1.16
===> patch-message [xpkgwedge-1.16] ===> Patching for xpkgwedge-1.16
=> Substituting "paths" in /usr/bsd/var/tmp/pkgtools/xpkgwedge/work/pkgxmkmf
=> Substituting "foo" in xpkgwedge.def
===> wrapper-message [xpkgwedge-1.16] ===> Creating toolchain wrappers for 
xpkgwedge-1.16
===> test-message [xpkgwedge-1.16] ===> Testing for xpkgwedge-1.16
===> _flavor-check-vulnerable [xpkgwedge-1.16] ===> Checking for 
vulnerabilities in xpkgwedge-1.16
===> install-message [xpkgwedge-1.16] ===> Installing for xpkgwedge-1.16
=> Creating installation directories
=> Running PRE-INSTALL script actions
/usr/bsd/bin/install-sh -d -o netbsd -g netbsd -m 755 /usr/bsd/lib/X11/config
/usr/bsd/bin/install-sh -c -o netbsd -g netbsd -m 644 
/usr/bsd/var/tmp/pkgtools/xpkgwedge/work/xpkgwedge.def /usr/bsd/lib/X11/config
/usr/bsd/bin/install-sh -c -o netbsd -g netbsd -m 755 
/usr/bsd/var/tmp/pkgtools/xpkgwedge/work/pkgxmkmf /usr/bsd/bin/pkgxmkmf
/usr/xpg4/bin/sh: line 0: [: 6.5: integer expression expected
patching file sgi.cf
Hunk #1 succeeded at 231 with fuzz 2 (offset 53 lines).
Hunk #2 FAILED at 243.
Hunk #3 FAILED at 309.
Hunk #4 succeeded at 293 (offset 12 lines).
2 out of 4 hunks FAILED -- saving rejects to file sgi.cf.rej
patching file sgiLib.rules
Hunk #1 succeeded at 78 with fuzz 2 (offset -19 lines).
*** Error code 1

Stop.
bmake: stopped in /usr/bsd/src/pkgtools/xpkgwedge
*** Error code 1

Stop.
bmake: stopped in /usr/bsd/src/pkgtools/xpkgwedge
*** Error code 1

Stop.
bmake: stopped in /usr/bsd/src/pkgtools/xpkgwedge
*** Error code 1

Stop.
bmake: stopped in /usr/bsd/src/pkgtools/xpkgwedge

>How-To-Repeat:

I don't know why anything is referring to /usr/xpg4/bin/sh - although /usr/xpg4 
is a symlink to bsd, so it's actually using /usr/bsd/bin/sh (itself a symlink 
to pkgsrc bash).  /usr/xpg4 does not feature in the netbsd user's $PATH.

The fact that bash-3 now restricts features and syntax if invoked as 'sh' might 
explain the problem:

Wherever the failing test is being performed (and might this be the package 
Makefile itself?) it appears that only a major version was expected, rather 
than a (co-incidentally) floating-point value.

Commenting out the checks in the Makefile to leave the IRIX6 path as the only 
option doesn't change the situation, though, so the pkgsrc Makefile doesn't 
look to be at fault here.
>Fix: