pkg/39859: net/rsync should pull in libiconv

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         39859
>Category:       pkg
>Synopsis:       net/rsync should pull in libiconv
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 03 11:10:00 +0000 2008
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
SunOS spare280 5.10 Generic_137111-07 sun4u sparc SUNW,Sun-Fire-280R

>Description:
net/rsync can use libiconv. It checks for the presence of it via autoconf. But 
due to suboptimal tests (or usage of their results), using gcc under Solaris, 
the build fails. Solaris' libiconv is considered sufficient, which it is not. 
Using the Sun Studio compiler, the tests fails in a different way, and libiconv 
is not used. See

https://bugzilla.samba.org/show_bug.cgi?id=5532

for reference.
>How-To-Repeat:

>Fix:
Adding

.include "../../converters/libiconv/buildlink3.mk"

fixes the problem. Maybe this could be done conditionally (only for SunOS), but 
I think it is not a bad idea in general.