Re: PR/39797 CVS commit: pkgsrc/pkgtools/libnbcompat

["Stuart Shelton" <srcshelton%gmail.com@localhost>]

The following reply was made to PR pkg/39797; it has been noted by GNATS.

From: "Stuart Shelton" <srcshelton%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost, joerg%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
pkgsrc-bugs%netbsd.org@localhost
Subject: Re: PR/39797 CVS commit: pkgsrc/pkgtools/libnbcompat
Date: Thu, 30 Oct 2008 17:38:16 +0000

 More problems here, I'm afraid:
 
 cc -I/usr/bsd/include -D__inline__=inline -D__DBINTERFACE_PRIVATE -I.
 -I.  -O2 -n32 -DHAVE_CONFIG_H -c sha2.c
 cc-3970 cc: WARNING File = sha2.c, Line = 505
   conversion from pointer to same-sized integral type (potential portability
           problem)
 
         if ((uintptr_t)data % 4 == 0) {
             ^
 
 cc-3970 cc: WARNING File = sha2.c, Line = 813
   conversion from pointer to same-sized integral type (potential portability
           problem)
 
         if ((uintptr_t)data % 8 == 0) {
             ^
 
 cc -I/usr/bsd/include -D__inline__=inline -D__DBINTERFACE_PRIVATE -I.
 -I.  -O2 -n32 -DHAVE_CONFIG_H -c sha2hl.c
 cc-1164 cc: WARNING File = sha2hl.c, Line = 92
   Argument of type "char *" is incompatible with parameter of type
           "unsigned char *".
 
         return (num < 0 ? 0 : SHA256_End(&ctx, buf));
                                                ^
 
 cc-1119 cc: WARNING File = sha2hl.c, Line = 119
   The "return" expression type differs from the function return type.
 
         return ret;
                ^
 
 cc-1515 cc: WARNING File = sha2hl.c, Line = 166
   A value of type "char *" cannot be assigned to an entity of type
           "unsigned char *".
 
         if ((ret = buffer) != NULL) {
                  ^
 
 cc-1119 cc: WARNING File = sha2hl.c, Line = 179
   The "return" expression type differs from the function return type.
 
         return ret;
                ^
 
 cc-1515 cc: WARNING File = sha2hl.c, Line = 226
   A value of type "char *" cannot be assigned to an entity of type
           "unsigned char *".
 
         if ((ret = buffer) != NULL) {
                  ^
 
 cc-1119 cc: WARNING File = sha2hl.c, Line = 239
   The "return" expression type differs from the function return type.
 
         return ret;
                ^
 
 cc -I/usr/bsd/include -D__inline__=inline -D__DBINTERFACE_PRIVATE -I.
 -I.  -O2 -n32 -DHAVE_CONFIG_H -c fts.c
 cc-1552 cc: WARNING File = __fts13.c, Line = 647
   The variable "nostat" is set but never used.
 
         int adjust, cderrno, descend, len, level, nlinks, saved_errno, nostat;
                                                                        ^
 
 cc-1174 cc: WARNING File = __fts13.c, Line = 1021
   The variable "len" was declared but never referenced.
 
         size_t len;
                ^
 
 cc -I/usr/bsd/include -D__inline__=inline -D__DBINTERFACE_PRIVATE -I.
 -I.  -O2 -n32 -DHAVE_CONFIG_H -c
 
/usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029/db/btree/bt_close.c
 cc-1101 cc: WARNING File = ./nbcompat/db.h, Line = 47
   "pgno_t" has already been declared in the current scope.
 
   typedef uint32_t      pgno_t;
                         ^
 
 cc -I/usr/bsd/include -D__inline__=inline -D__DBINTERFACE_PRIVATE -I.
 -I.  -O2 -n32 -DHAVE_CONFIG_H -c
 /usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029/db/hash/hash.c
 cc-1101 cc: WARNING File = ./nbcompat/db.h, Line = 47
   "pgno_t" has already been declared in the current scope.
 
   typedef uint32_t      pgno_t;
                         ^
 
 cc-1164 cc: ERROR File =
 /usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029/db/hash/hash.c,
 Line = 532
   Argument of type "int" is incompatible with parameter of type "DBT *".
 
         return (hash_access(hashp, HASH_GET, __UNCONST(key), data));
                                              ^
 
 cc-1164 cc: ERROR File =
 /usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029/db/hash/hash.c,
 Line = 551
   Argument of type "int" is incompatible with parameter of type "DBT *".
 
             HASH_PUTNEW : HASH_PUT, __UNCONST(key), __UNCONST(data)));
                                     ^
 
 cc-1164 cc: ERROR File =
 /usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029/db/hash/hash.c,
 Line = 551
   Argument of type "int" is incompatible with parameter of type "DBT *".
 
             HASH_PUTNEW : HASH_PUT, __UNCONST(key), __UNCONST(data)));
                                                     ^
 
 cc-1164 cc: ERROR File =
 /usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029/db/hash/hash.c,
 Line = 568
   Argument of type "int" is incompatible with parameter of type "DBT *".
 
         return hash_access(hashp, HASH_DELETE, __UNCONST(key), NULL);
                                                ^
 
 cc-1174 cc: WARNING File =
 /usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029/db/hash/hash.c,
 Line = 39
   The variable "rcsid" was declared but never referenced.
 
   __RCSID("$NetBSD: hash.c,v 1.1 2008/10/10 00:21:43 joerg Exp $");
   ^
 
 4 errors detected in the compilation of
 
"/usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029/db/hash/hash.c".
 *** Error code 2
 
 Stop.
 bmake: stopped in
 /usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081029
 *** Error code 1
 
 Stop.
 bmake: stopped in /usr/bsd/src/pkgtools/libnbcompat
 *** Error code 1
 
 Stop.
 bmake: stopped in /usr/bsd/src/pkgtools/libnbcompat
 
 
 There are many many instances of the 'pgno_t' warning, and a '__RCSID'
 error for every file it appears in (is this being compiled with
 '-Wall', which makes MIPSpro very verbose about trivial warnings?).
 In any case, it looks as if __UNCONST is undefined and so causing the
 compilation failures.
 
 
 2008/10/28 Joerg Sonnenberger <joerg%netbsd.org@localhost>:
 > The following reply was made to PR pkg/39797; it has been noted by GNATS.
 >
 > From: Joerg Sonnenberger <joerg%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc:
 > Subject: PR/39797 CVS commit: pkgsrc/pkgtools/libnbcompat
 > Date: Tue, 28 Oct 2008 15:15:18 +0000 (UTC)
 >
 >  Module Name:   pkgsrc
 >  Committed By:  joerg
 >  Date:          Tue Oct 28 15:15:18 UTC 2008
 >
 >  Modified Files:
 >        pkgsrc/pkgtools/libnbcompat: Makefile
 >        pkgsrc/pkgtools/libnbcompat/files/nbcompat: queue.h
 >
 >  Log Message:
 >  Add circleq support. Bump to 20081028. Should fix IRIX build from
 >  PR 39797.
 >
 >
 >  To generate a diff of this commit:
 >  cvs rdiff -r1.65 -r1.66 pkgsrc/pkgtools/libnbcompat/Makefile
 >  cvs rdiff -r1.4 -r1.5 pkgsrc/pkgtools/libnbcompat/files/nbcompat/queue.h
 >
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 >
 >