pkg/39797: libnbcompat-20081010 fails to build on IRIX

[srcshelton%gmail.com@localhost]

>Number:         39797
>Category:       pkg
>Synopsis:       libnbcompat-20081010 fails to build on IRIX
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 24 15:05:00 +0000 2008
>Originator:     Stuart Shelton
>Release:        pkgsrc latest form CVS
>Organization:
>Environment:
IRIX 6.5.30; MIPSpro Compilers Version 7.4.4m.
>Description:

libnbcompat fails with:

cc-3970 cc: WARNING File = sha2.c, Line = 505
  conversion from pointer to same-sized integral type (potential portability
          problem)

        if ((uintptr_t)data % 4 == 0) {
            ^

cc-3970 cc: WARNING File = sha2.c, Line = 813
  conversion from pointer to same-sized integral type (potential portability
          problem)

        if ((uintptr_t)data % 8 == 0) {
            ^

cc-1164 cc: WARNING File = sha2hl.c, Line = 92
  Argument of type "char *" is incompatible with parameter of type
          "unsigned char *".

        return (num < 0 ? 0 : SHA256_End(&ctx, buf));
                                               ^

cc-1119 cc: WARNING File = sha2hl.c, Line = 119
  The "return" expression type differs from the function return type.

        return ret;
               ^

cc-1515 cc: WARNING File = sha2hl.c, Line = 166
  A value of type "char *" cannot be assigned to an entity of type
          "unsigned char *".

        if ((ret = buffer) != NULL) {
                 ^

cc-1119 cc: WARNING File = sha2hl.c, Line = 179
  The "return" expression type differs from the function return type.

        return ret;
               ^

cc-1515 cc: WARNING File = sha2hl.c, Line = 226
  A value of type "char *" cannot be assigned to an entity of type
          "unsigned char *".

        if ((ret = buffer) != NULL) {
                 ^

cc-1119 cc: WARNING File = sha2hl.c, Line = 239
  The "return" expression type differs from the function return type.

        return ret;
               ^

cc-1552 cc: WARNING File = __fts13.c, Line = 647
  The variable "nostat" is set but never used.

        int adjust, cderrno, descend, len, level, nlinks, saved_errno, nostat;
                                                                       ^

cc-1174 cc: WARNING File = __fts13.c, Line = 1021
  The variable "len" was declared but never referenced.

        size_t len;
               ^

cc-1101 cc: WARNING File = ./nbcompat/db.h, Line = 47
  "pgno_t" has already been declared in the current scope.

  typedef uint32_t      pgno_t;
                        ^

cc-1020 cc: ERROR File = /usr/include/mpool.h, Line = 50
  The identifier "CIRCLEQ_ENTRY" is undefined.

        CIRCLEQ_ENTRY(_bkt) hq;         /* hash queue */
        ^

cc-1065 cc: ERROR File = /usr/include/mpool.h, Line = 50
  A semicolon is expected at this point.

        CIRCLEQ_ENTRY(_bkt) hq;         /* hash queue */
                            ^

cc-1020 cc: ERROR File = /usr/include/mpool.h, Line = 51
  The identifier "CIRCLEQ_ENTRY" is undefined.

        CIRCLEQ_ENTRY(_bkt) q;          /* lru queue */
        ^

cc-1101 cc: ERROR File = /usr/include/mpool.h, Line = 51
  "_bkt" has already been declared in the current scope.

        CIRCLEQ_ENTRY(_bkt) q;          /* lru queue */
                      ^

cc-1065 cc: ERROR File = /usr/include/mpool.h, Line = 51
  A semicolon is expected at this point.

        CIRCLEQ_ENTRY(_bkt) q;          /* lru queue */
                            ^

cc-1020 cc: ERROR File = /usr/include/mpool.h, Line = 61
  The identifier "CIRCLEQ_HEAD" is undefined.

        CIRCLEQ_HEAD(_lqh, _bkt) lqh;   /* lru queue head */
        ^

cc-1018 cc: ERROR File = /usr/include/mpool.h, Line = 61
  An unmatched left parentheses "(" appears in an expression.

        CIRCLEQ_HEAD(_lqh, _bkt) lqh;   /* lru queue head */
                         ^

cc-1065 cc: ERROR File = /usr/include/mpool.h, Line = 61
  A semicolon is expected at this point.

        CIRCLEQ_HEAD(_lqh, _bkt) lqh;   /* lru queue head */
                               ^

cc-1020 cc: ERROR File = /usr/include/mpool.h, Line = 63
  The identifier "CIRCLEQ_HEAD" is undefined.

        CIRCLEQ_HEAD(_hqh, _bkt) hqh[HASHSIZE];
        ^

cc-1018 cc: ERROR File = /usr/include/mpool.h, Line = 63
  An unmatched left parentheses "(" appears in an expression.

        CIRCLEQ_HEAD(_hqh, _bkt) hqh[HASHSIZE];
                         ^

cc-1101 cc: ERROR File = /usr/include/mpool.h, Line = 63
  "_bkt" has already been declared in the current scope.

        CIRCLEQ_HEAD(_hqh, _bkt) hqh[HASHSIZE];
                           ^

cc-1065 cc: ERROR File = /usr/include/mpool.h, Line = 63
  A semicolon is expected at this point.

        CIRCLEQ_HEAD(_hqh, _bkt) hqh[HASHSIZE];
                               ^

12 errors detected in the compilation of 
"/usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081010/db/btree/bt_close.c".
*** Error code 2

Stop.
bmake: stopped in 
/usr/bsd/var/tmp/pkgtools/libnbcompat/work/libnbcompat-20081010
*** Error code 1

Stop.
bmake: stopped in /usr/bsd/src/pkgtools/libnbcompat
*** Error code 1

Stop.
bmake: stopped in /usr/bsd/src/pkgtools/libnbcompat

>How-To-Repeat:

Hmm - mpool.h is a system include, but:

# grep -R CIRCLEQ /usr/include/
/usr/include/mpool.h:       CIRCLEQ_ENTRY(_bkt) hq;            /* hash queue */
/usr/include/mpool.h:       CIRCLEQ_ENTRY(_bkt) q;             /* lru queue */
/usr/include/mpool.h:       CIRCLEQ_HEAD(_lqh, _bkt) lqh;      /* lru queue 
head */
/usr/include/mpool.h:       CIRCLEQ_HEAD(_hqh, _bkt) hqh[HASHSIZE];

... it doesn't seem to be defined anywhere!

Something strange's going on here...
>Fix:

Does libnbcompat on IRIX need to be modified so that it *doesn't* support 
OS-native mpool functionality?