pkg/39083: firefox3 compile error: missing ')' in jemalloc.c

[sd4dfg2%hotmail.com@localhost]

>Number:         39083
>Category:       pkg
>Synopsis:       firefox3 compile error: missing ')' in jemalloc.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 02 13:35:00 +0000 2008
>Originator:     Rob Quinn
>Release:        Solaris with pkgsrc-current
>Organization:
>Environment:
>Description:
make[3]: Leaving directory `/usr/obj/pkg/www/firefox3/work/mozilla/probes'
make[3]: Entering directory 
`/usr/obj/pkg/www/firefox3/work/mozilla/memory/jemalloc'
jemalloc.c
gcc -o jemalloc.o -c  -DOSTYPE=\"SunOS5\" -DOSARCH=SunOS  -I. -I.  
-I../../dist/include   -I../../dist/include/jemalloc -I../../dist/include/nspr 
-I/usr/pkg/include    -I../../dist/sdk/include -I/usr/openwin/include   -fPIC 
-DPNG_NO_ASSEMBLER_CODE -I/usr/pkg/include -I/usr/pkg/include/python2.4 
-I/usr/include -I/usr/pkg/include/freetype2  -I/usr/openwin/include 
-Wno-long-long -O -mv8 -pipe -I/usr/pkg/include -I/usr/pkg/include/python2.4 
-I/usr/include -I/usr/pkg/include/freetype2 -fno-strict-aliasing -pthreads  
-DNDEBUG -DTRIMMED -pipe  -DPNG_NO_ASSEMBLER_CODE -I/usr/pkg/include 
-I/usr/pkg/include/python2.4 -I/usr/include -I/usr/pkg/include/freetype2  
-I/usr/openwin/include -include ../../mozilla-config.h -DMOZILLA_CLIENT 
-Wp,-MD,.deps/jemalloc.pp jemalloc.c
jemalloc.c:5778:28: missing ')' in expression
make[3]: *** [jemalloc.o] Error 1
make[3]: Leaving directory 
`/usr/obj/pkg/www/firefox3/work/mozilla/memory/jemalloc'
make[2]: *** [libs_tier_base] Error 2
make[2]: Leaving directory `/usr/obj/pkg/www/firefox3/work/mozilla'
make[1]: *** [tier_base] Error 2
make[1]: Leaving directory `/usr/obj/pkg/www/firefox3/work/mozilla'
gmake: *** [default] Error 2
*** Error code 2

>How-To-Repeat:
The block looks like this, with the error on the line marked "this line".


#ifdef MOZ_MEMORY_DARWIN
VISIBLE
inline void *
moz_memalign(size_t alignment, size_t size)
#elif (defined(MOZ_MEMORY_SOLARIS))
#  ifdef __SUNPRO_C
void *
memalign(size_t alignment, size_t size);
#pragma no_inline(memalign)
#  elif (defined(__GNU_C__)                   ***this line****
__attribute__((noinline))
#  endif
VISIBLE
void *
memalign(size_t alignment, size_t size)
#else
VISIBLE
inline void *
memalign(size_t alignment, size_t size)
#endif

>Fix:
I'm compiling with the obvious fix now, it just seems odd that a simple mistake 
like this made it into production/release code.