Re: pkg/37740: open-vm-tools misses pcre build dependency

[OBATA Akio <obache%NetBSD.org@localhost>]

The following reply was made to PR pkg/37740; it has been noted by GNATS.

From: OBATA Akio <obache%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/37740: open-vm-tools misses pcre build dependency
Date: Sun, 20 Jan 2008 22:18:12 +0900

 On Fri, 11 Jan 2008 03:30:05 +0900, Jeremy C. Reed 
<reed%reedmedia.net@localhost> 
 wrote:
 
 >  If open-vm-tools doesn't need pcre directly, then this is probably not 
 the
 >  correct fix.
 >
 >  What does the following tell us?
 >
 >  pkg_info -n gtk2+ | egrep 'Information|glib'
 >
 >  pkg_info -n glib2 | egrep 'Information|pcre'
 >
 >  The pcre buildlink was included on 08-Nov-07 but the dependency was not
 >  bumped. This was done during the update to 2.14.3.
 >
 >  This has been reported (not including my own similar reports):
 >
 >  http://archive.netbsd.se/?ml=netbsd-tech-pkg&a=2007-11&m=5701705
 >
 >  and
 >
 >  http://archive.netbsd.se/?ml=netbsd-current-users&a=2007-11&m=5735883
 >
 >  My recommendation is to abuse BUILDLINK_API_DEPENDS.glib2 for this. See 
 my
 >  email at http://archive.netbsd.se/?ml=netbsd-tech-pkg&a=2008-01&m=6034802
 >  (I has posted about this other times also, but never received any answer
 >  to this ongoing problem.)
 
 Following patch may fix this problem.
 
 Index: buildlink3.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/glib2/buildlink3.mk,v
 retrieving revision 1.14
 diff -u -r1.14 buildlink3.mk
 --- buildlink3.mk       8 Nov 2007 19:52:21 -0000       1.14
 +++ buildlink3.mk       20 Jan 2008 13:12:02 -0000
 @@ -17,9 +17,18 @@
  BUILDLINK_PKGSRCDIR.glib2?=    ../../devel/glib2
  .endif # GLIB2_BUILDLINK3_MK
 
 +GLIB2_USING_BUNDLED_PCRE= \
 +        if ${PKG_INFO} -qe 'glib2<=2.14.2'; then                       \
 +                ${ECHO} yes;                                           \
 +        else                                                           \
 +                ${ECHO} no;                                            \
 +        fi
 +
  .include "../../converters/libiconv/buildlink3.mk"
  .include "../../devel/gettext-lib/buildlink3.mk"
 +.if ${GLIB2_USING_BUNDLED_PCRE} == "no"
  .include "../../devel/pcre/buildlink3.mk"
 +.endif
  .include "../../mk/pthread.buildlink3.mk"
 
  BUILDLINK_DEPTH:=      ${BUILDLINK_DEPTH:S/+$//}
 
 
 -- 
 "Of course I love NetBSD":-)
 OBATA Akio / obache%NetBSD.org@localhost