pkg/36825: bsd.options.mk is broken when building packages on Solaris 10

[cjsvance%gmail.com@localhost]

>Number:         36825
>Category:       pkg
>Synopsis:       bsd.options.mk is broken when building packages on Solaris 10
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 24 08:30:00 +0000 2007
>Originator:     Christopher Vance
>Release:        pkgsrc-current
>Organization:
RTA / Abacorix
>Environment:
SunOS tinderbox 5.10 Generic_118822-25 sun4u sparc SUNW,UltraAX-i2

>Description:
Sun's /bin/sh does not like the syntax

for l;
do ... done

>How-To-Repeat:
Attempt to build apache22
>Fix:
--- /usr/pkgsrc/mk/bsd.options.mk.orig  Fri Aug 24 16:16:46 2007
+++ /usr/pkgsrc/mk/bsd.options.mk       Fri Aug 24 15:55:55 2007
@@ -388,7 +388,7 @@
        @${ECHO} "or "${PKG_OPTIONS_VAR:Q}"."
        @set -- dummy ${PKG_OPTIONS_DEPRECATED_WARNINGS}; \
        if ${TEST} $$# -gt 1; then ${ECHO}; fi; \
-       for l; \
+       for l in $$*; \
        do \
                if ${TEST} "$$l" = "dummy"; then continue; fi; \
                ${ECHO} "$$l"; \
@@ -420,7 +420,7 @@
 .    endif
        @set -- dummy ${PKG_OPTIONS_DEPRECATED_WARNINGS}; \
        if ${TEST} $$# -gt 1; then ${ECHO}; fi; \
-       for l; \
+       for l in $$*; \
        do \
                if ${TEST} "$$l" = "dummy"; then continue; fi; \
                ${ECHO} "$$l"; \