Re: structure fxsave* / fxsave64 changed from 102x to 11.0?

[Riccardo Mottola <riccardo.mottola%libero.it@localhost>]

Hi Taylor,

Taylor R Campbell wrote:
> Sorry, we broke the API compatibility here.  Fortunately the fix is
> very simple -- just insert an ampersand, and it will work equally well
> on older NetBSD and newer NetBSD:
>
> -# define XMM_sig(p,i) (((struct fxsave64*)(p)->uc_mcontext.__fpregs)->fx_xmm[i])
> +# define XMM_sig(p,i) (((struct fxsave64*)&(p)->uc_mcontext.__fpregs)->fx_xmm[i])

thank you for the quick fix. I searched for it, but search engines did 
not yet index it apparently.

I applied it and confirmed it compiles on both 10.2 and 11.0 amd64. Very 
good. I still need to test better i386, PPC and SPARC64. But I cycle 
those test muych more rarely and only when Intel is stable.

I hope I can kick out a release soon with 11.0 support!

I am a little bit struggling with my laptop running 11.0, but that is a 
separate issue! Please follow up on my thread.

> This was raised in PR kern/60539: XSAVE changes break ucontext
> userspace API <https://gnats.NetBSD.org/60539>; see background there
> if you're curious.

I am curious, it is very technical I understand that with ACX ther ewoul 
dbe issues when reading back the register.
I did run and I see no particular problems, which is a good sign.
I cited it in the fix commit, so it remains traced whatever will happen 
in the future.

Thanks a lot!

Riccardi