NetBSD-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Not a blocker for 10.0: synaptics touchpad lies about coordinates



In my quite old laptop there is a synaptics-like touchpad that lies
about its coordinate range. As a result it doesn't work: all its reports
are filtered out as being "out of bounds". This can be remedied by a
set of sysctls to correct this, except these sysctls are also rejected
for being out of (other) bounds. The patch below "fixes" this in a hacky
way (by removing those bound checks).

I corresponded with blymn@ when 10 was branched and he wanted to make a
proper fix, but apparently that didn't make it into 10.0.

It's not a showstopper since I can easily build a custom kernel with
this patch, but for 10.1 it would be nice to have.

--- usr/src/sys/dev/pckbport/synaptics.c.dist	2023-11-08 21:15:21.679298167 +0100
+++ usr/src/sys/dev/pckbport/synaptics.c	2023-11-08 21:16:21.874551909 +0100
@@ -263,7 +263,7 @@
 	}
 
 	if (synaptics_edge_right != synaptics_old_vert_edge) {
-		if (synaptics_edge_right >= synaptics_actual_edge_right) {
+		if (0 && synaptics_edge_right >= synaptics_actual_edge_right) {
 			synaptics_vert_pct = 0;
 			synaptics_edge_right = synaptics_actual_edge_right;
 		} else {
@@ -284,7 +284,7 @@
 	}
 
 	if (synaptics_edge_bottom != synaptics_old_horiz_edge) {
-		if (synaptics_edge_bottom <= synaptics_actual_edge_bottom) {
+		if (0 && synaptics_edge_bottom <= synaptics_actual_edge_bottom) {
 			synaptics_vert_pct = 0;
 			synaptics_edge_bottom = synaptics_actual_edge_bottom;
 		} else {

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert                            <rhialto/at/falu.nl>
\X/ There is no AI. There is just someone else's work.           --I. Rose

Attachment: signature.asc
Description: PGP signature



Home | Main Index | Thread Index | Old Index