Re: Future Patch

["Chavdar Ivanov" <ci4ic4%gmail.com@localhost>]

On 01/02/2008, David Dudley <DavidDu%cctexas.com@localhost> wrote:
> I've got a patch for 'pcidevs' and 'pucdata.c' that I'd like to submit
> that will allow Net to directly support the "B&B Electronics" MIPort
> multi-port RS232/RS485 comm cards (big deal, it's 3 lines in each
> file).
>
> I've never submitted a patch before, so was wondering if I could get
> some direction on the format to use, and how to do it correctly?


Basically edit your files in your own copy of the CVS tree, then cd to
/usr/src (assuming you keep it there) and do:

     cvs diff -u sys/dev/pci/pcidevs

(this is just an example; I have added a bogus entry at the end of pcidevs).

The result would be the patch in the '-u' format:

13:28 (root~loan8) /usr/src
% cvs diff -u sys/dev/pci/pcidevs
Index: sys/dev/pci/pcidevs
===================================================================
RCS file: /cvsroot/src/sys/dev/pci/pcidevs,v
retrieving revision 1.926
diff -u -r1.926 pcidevs
--- sys/dev/pci/pcidevs 11 Jan 2008 20:47:21 -0000      1.926
+++ sys/dev/pci/pcidevs 1 Feb 2008 13:28:52 -0000
@@ -4041,3 +4041,5 @@

 /* Zoran products */
 product ZORAN ZR36120  0x6120 Video Controller
+/* TeSt PrOdUcT */
+product TeSt TsT1234    0x9900 Test PRoduct


Then do a send-pr attaching your patches (I use the web interface).

Try if the patch works by restoring the original file and then
applying it - the result should be the same as your own modified copy.

>
> Also got one in the works (for the future) for supporting the "Novatel
> Wireless Merlin S720" Cellular card.
>
>
> David Dudley
>
>


-- 
----------------------------------------------------------------
/dev/random says:
        I don't suffer from insanity. I enjoy every minute of it.
----------------------------------------------------------------
Chavdar Ivanov   | Talbot Way, Small Heath Business Park
Delcam UK        | Birmingham B10 0HJ, United Kingdom
Customer Support | (+44)121-6831014
----------------------------------------------------------------