NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-arm/52163 - support for gpio for Xscale



The following reply was made to PR port-arm/52163; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: port-arm/52163 - support for gpio for Xscale
Date: Tue, 16 May 2017 16:27:37 +0800 (+08)

 Forward with correct PR category so it will get logged.
 
 
 On Mon, 15 May 2017, smesgr wrote:
 
 > Hi Paul,
 > 
 > thanks for looking into the PR. So you would suggest moving all/most of the 
 > NGPIO stuff into "if_pxagpio_gpio.c" or something along this line?
 
 I would suggest just removing the #if NGPIO conditionals.  Compile that code 
 always.
 
 You will also need to separate the "search for children" code, which looks like 
 it consists only of a call to config_found_ia(..," gpiobus", ...), into a 
 separate function pxagpio_rescan() and add the rescan function to the 
 CFATTACH_DECL_NEW (you'll need to update that to use CFATTACH_DECL3_NEW).
 
 
 
 +------------------+--------------------------+----------------------------+
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
 +------------------+--------------------------+----------------------------+
 


Home | Main Index | Thread Index | Old Index