NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-arm/52163 - support for gpio for Xscale

The following reply was made to PR port-arm/52163; it has been noted by GNATS.

From: Paul Goyette <>
Subject: Re: port-arm/52163 - support for gpio for Xscale
Date: Tue, 16 May 2017 16:27:15 +0800 (+08)

 Forward with correct PR category in subject line so it will get added to the 
 audit trail!
 The driver looks pretty reasonable to me, but I've got no way to test it. 
 Hopefully one of the other folks here with appropriate hardware would be able 
 to jump in.
 One thing I did notice, is there's a large chunk of code conditionally compiled 
 based on #if NGPIO.  In a "modular" world, the gpio module could be loaded 
 later, so it would probably be best not to "cripple" the controller driver just 
 because the child driver is not currently present.
 Thanks for the contribution (and thanks for the completeness, including man 
 pages, configuration database update, etc.)!
 | Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
 | (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
 | Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |

Home | Main Index | Thread Index | Old Index