Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use S_IFDIR instead of _S

On Jan 11, 2017, at 10:20 AM, Christos Zoulas <christos%zoulas.com@localhost> wrote:

The following reply was made to PR bin/51825; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost,
yaneurabeya%gmail.com@localhost
Cc:
Subject: Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use S_IFDIR instead of _S_IFDIR
Date: Wed, 11 Jan 2017 13:17:48 -0500

On Jan 11, 9:15am, yaneurabeya%gmail.com@localhost ("Ngie Cooper (yaneurabeya)") wrote:
-- Subject: Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use S_IFDIR instead

| Also, use #include =E2=80=9Ch_macros.h=E2=80=9D and CPPFLAGS.t_glob.c to =
| direct make/cc where to find the h_macros.h header (this diff reduces =
| t_glob.c with FreeBSD a bit as h_macros.h is located in a separate =
| directory path on FreeBSD).
| Thanks!
| -Ngie

This "../../../" business is in other places; let's decide how to fix it
properly... Ideally by getting rid of it and moving the functionality to
atf itself as appropriate.

Hi!

I noticed that the _S_IFDIR portion of the change wasn’t accepted — was there a particular reason why the other form is preferred (_S_IFDIR)?

Thanks!

-Ngie

cvs diff -u lib/libc/gen/t_glob.c

Index: lib/libc/gen/t_glob.c

===================================================================

RCS file: /cvsroot/src/tests/lib/libc/gen/t_glob.c,v

retrieving revision 1.4

diff -u -r1.4 t_glob.c

--- lib/libc/gen/t_glob.c 13 Jan 2017 21:30:41 -0000 1.4

+++ lib/libc/gen/t_glob.c 14 Jan 2017 01:02:02 -0000

@@ -146,7 +146,7 @@

memset(st, 0, sizeof(*st));

if (strcmp(buf, "a") == 0 || strcmp(buf, "a/b") == 0) {

- st->st_mode |= _S_IFDIR;

+ st->st_mode |= S_IFDIR;

return 0;

}