NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use S_IFDIR instead of _S_IFDIR
The following reply was made to PR bin/51825; it has been noted by GNATS.
From: "Ngie Cooper (yaneurabeya)" <yaneurabeya%gmail.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: gnats-admin%netbsd.org@localhost,
netbsd-bugs%netbsd.org@localhost
Subject: Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use S_IFDIR instead of
_S_IFDIR
Date: Fri, 13 Jan 2017 17:02:55 -0800
--Apple-Mail=_D3C3D313-E562-417C-BD34-685916D3DEEA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
> On Jan 11, 2017, at 10:20 AM, Christos Zoulas <christos%zoulas.com@localhost> =
wrote:
>=20
> The following reply was made to PR bin/51825; it has been noted by =
GNATS.
>=20
> From: christos%zoulas.com@localhost (Christos Zoulas)
> To: gnats-bugs%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost, =
netbsd-bugs%netbsd.org@localhost,=20
> yaneurabeya%gmail.com@localhost
> Cc:=20
> Subject: Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use S_IFDIR =
instead of _S_IFDIR
> Date: Wed, 11 Jan 2017 13:17:48 -0500
>=20
> On Jan 11, 9:15am, yaneurabeya%gmail.com@localhost ("Ngie Cooper =
(yaneurabeya)") wrote:
> -- Subject: Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use S_IFDIR =
instead
>=20
> | Also, use #include =3DE2=3D80=3D9Ch_macros.h=3DE2=3D80=3D9D and =
CPPFLAGS.t_glob.c to =3D
> | direct make/cc where to find the h_macros.h header (this diff =
reduces =3D
> | t_glob.c with FreeBSD a bit as h_macros.h is located in a separate =
=3D
> | directory path on FreeBSD).
> | Thanks!
> | -Ngie
>=20
> This "../../../" business is in other places; let's decide how to fix =
it
> properly... Ideally by getting rid of it and moving the functionality =
to
> atf itself as appropriate.
Hi!
I noticed that the _S_IFDIR portion of the change wasn=E2=80=99t =
accepted =E2=80=94 was there a particular reason why the other form is =
preferred (_S_IFDIR)?
Thanks!
-Ngie
cvs diff -u lib/libc/gen/t_glob.c=20
Index: lib/libc/gen/t_glob.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsroot/src/tests/lib/libc/gen/t_glob.c,v
retrieving revision 1.4
diff -u -r1.4 t_glob.c
--- lib/libc/gen/t_glob.c 13 Jan 2017 21:30:41 -0000 1.4
+++ lib/libc/gen/t_glob.c 14 Jan 2017 01:02:02 -0000
@@ -146,7 +146,7 @@
memset(st, 0, sizeof(*st));
=20
if (strcmp(buf, "a") =3D=3D 0 || strcmp(buf, "a/b") =3D=3D 0) {
- st->st_mode |=3D _S_IFDIR;
+ st->st_mode |=3D S_IFDIR;
return 0;
}
=20
--Apple-Mail=_D3C3D313-E562-417C-BD34-685916D3DEEA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
charset=utf-8
<html><head><meta http-equiv=3D"Content-Type" content=3D"text/html =
charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" =
class=3D""><br class=3D""><div><blockquote type=3D"cite" class=3D""><div =
class=3D"">On Jan 11, 2017, at 10:20 AM, Christos Zoulas <<a =
href=3D"mailto:christos%zoulas.com@localhost"; class=3D"">christos%zoulas.com@localhost</a>>=
wrote:</div><br class=3D"Apple-interchange-newline"><div class=3D""><div =
class=3D"">The following reply was made to PR bin/51825; it has been =
noted by GNATS.<br class=3D""><br class=3D"">From: <a =
href=3D"mailto:christos%zoulas.com@localhost"; class=3D"">christos%zoulas.com@localhost</a> =
(Christos Zoulas)<br class=3D"">To: <a =
href=3D"mailto:gnats-bugs%NetBSD.org@localhost"; =
class=3D"">gnats-bugs%NetBSD.org@localhost</a>, <a =
href=3D"mailto:gnats-admin%netbsd.org@localhost"; =
class=3D"">gnats-admin%netbsd.org@localhost</a>, <a =
href=3D"mailto:netbsd-bugs%netbsd.org@localhost"; =
class=3D"">netbsd-bugs%netbsd.org@localhost</a>, <br class=3D""><span =
class=3D"Apple-tab-span" style=3D"white-space:pre"> </span><a =
href=3D"mailto:yaneurabeya%gmail.com@localhost"; =
class=3D"">yaneurabeya%gmail.com@localhost</a><br class=3D"">Cc: <br =
class=3D"">Subject: Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use =
S_IFDIR instead of _S_IFDIR<br class=3D"">Date: Wed, 11 Jan 2017 =
13:17:48 -0500<br class=3D""><br class=3D""> On Jan 11, 9:15am, =
yaneurabeya%gmail.com@localhost ("Ngie Cooper (yaneurabeya)") wrote:<br class=3D""> =
-- Subject: Re: bin/51825: [PATCH] tests/lib/libc/t_glob: use S_IFDIR =
instead<br class=3D""><br class=3D""> | Also, use #include =
=3DE2=3D80=3D9Ch_macros.h=3DE2=3D80=3D9D and CPPFLAGS.t_glob.c to =3D<br =
class=3D""> | direct make/cc where to find the h_macros.h header =
(this diff reduces =3D<br class=3D""> | t_glob.c with FreeBSD a =
bit as h_macros.h is located in a separate =3D<br class=3D""> | =
directory path on FreeBSD).<br class=3D""> | Thanks!<br =
class=3D""> | -Ngie<br class=3D""><br class=3D""> This "../../../" =
business is in other places; let's decide how to fix it<br class=3D""> =
properly... Ideally by getting rid of it and moving the functionality =
to<br class=3D""> atf itself as appropriate.<br =
class=3D""></div></div></blockquote><br =
class=3D""></div><div>Hi!</div><div><span class=3D"Apple-tab-span" =
style=3D"white-space:pre"> </span>I noticed that the _S_IFDIR =
portion of the change wasn=E2=80=99t accepted =E2=80=94 was there a =
particular reason why the other form is preferred =
(_S_IFDIR)?</div><div>Thanks!</div><div>-Ngie</div><div><br =
class=3D""></div><div><div style=3D"margin: 0px; line-height: normal; =
font-family: 'Andale Mono'; color: rgb(40, 254, 20); background-color: =
rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D""> cvs=
diff -u lib/libc/gen/t_glob.c </span></div><div style=3D"margin: =
0px; line-height: normal; font-family: 'Andale Mono'; color: rgb(40, =
254, 20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">Index: =
lib/libc/gen/t_glob.c</span></div><div style=3D"margin: 0px; =
line-height: normal; font-family: 'Andale Mono'; color: rgb(40, 254, =
20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" =
class=3D"">=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D</span></di=
v><div style=3D"margin: 0px; line-height: normal; font-family: 'Andale =
Mono'; color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, =
0.901961);" class=3D""><span style=3D"font-variant-ligatures: =
no-common-ligatures" class=3D"">RCS file: =
/cvsroot/src/tests/lib/libc/gen/t_glob.c,v</span></div><div =
style=3D"margin: 0px; line-height: normal; font-family: 'Andale Mono'; =
color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, 0.901961);" =
class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
class=3D"">retrieving revision 1.4</span></div><div style=3D"margin: =
0px; line-height: normal; font-family: 'Andale Mono'; color: rgb(40, =
254, 20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">diff -u =
-r1.4 t_glob.c</span></div><div style=3D"margin: 0px; line-height: =
normal; font-family: 'Andale Mono'; color: rgb(40, 254, 20); =
background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">--- =
lib/libc/gen/t_glob.c 13 Jan 2017 21:30:41 =
-0000 1.4</span></div><div style=3D"margin: 0px; =
line-height: normal; font-family: 'Andale Mono'; color: rgb(40, 254, =
20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">+++ =
lib/libc/gen/t_glob.c 14 Jan 2017 01:02:02 =
-0000</span></div><div style=3D"margin: 0px; line-height: normal; =
font-family: 'Andale Mono'; color: rgb(40, 254, 20); background-color: =
rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">@@ =
-146,7 +146,7 @@</span></div><div style=3D"margin: 0px; line-height: =
normal; font-family: 'Andale Mono'; color: rgb(40, 254, 20); =
background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D""> =
memset(st, 0, sizeof(*st));</span></div><p =
style=3D"margin: 0px; line-height: normal; font-family: 'Andale Mono'; =
color: rgb(40, 254, 20); background-color: rgba(0, 0, 0, 0.901961); =
min-height: 14px;" class=3D""><span style=3D"font-variant-ligatures: =
no-common-ligatures" class=3D""> </span><br =
class=3D"webkit-block-placeholder"></p><div style=3D"margin: 0px; =
line-height: normal; font-family: 'Andale Mono'; color: rgb(40, 254, =
20); background-color: rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D""> =
if (strcmp(buf, "a") =3D=3D 0 || strcmp(buf, "a/b") =
=3D=3D 0) {</span></div><div style=3D"margin: 0px; line-height: normal; =
font-family: 'Andale Mono'; color: rgb(40, 254, 20); background-color: =
rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">- =
st->st_mode |=3D =
_S_IFDIR;</span></div><div style=3D"margin: 0px; line-height: normal; =
font-family: 'Andale Mono'; color: rgb(40, 254, 20); background-color: =
rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D"">+ =
st->st_mode |=3D =
S_IFDIR;</span></div><div style=3D"margin: 0px; line-height: normal; =
font-family: 'Andale Mono'; color: rgb(40, 254, 20); background-color: =
rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D""> =
return =
0;</span></div><div style=3D"margin: 0px; line-height: normal; =
font-family: 'Andale Mono'; color: rgb(40, 254, 20); background-color: =
rgba(0, 0, 0, 0.901961);" class=3D""><span =
style=3D"font-variant-ligatures: no-common-ligatures" class=3D""> =
}</span></div><p style=3D"margin: 0px; line-height: =
normal; font-family: 'Andale Mono'; color: rgb(40, 254, 20); =
background-color: rgba(0, 0, 0, 0.901961); min-height: 14px;" =
class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
class=3D""> </span><br class=3D"webkit-block-placeholder"></p><div =
class=3D""><span style=3D"font-variant-ligatures: no-common-ligatures" =
class=3D""><br class=3D""></span></div></div></body></html>=
--Apple-Mail=_D3C3D313-E562-417C-BD34-685916D3DEEA--
Home |
Main Index |
Thread Index |
Old Index