kern/50819: src/sys/dev/pci/if_et.c:2055: contradictory nested if ?

[dcb314%hotmail.com@localhost]

>Number:         50819
>Category:       kern
>Synopsis:       src/sys/dev/pci/if_et.c:2055: contradictory nested if ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 17 11:05:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160216
>Organization:
>Environment:
>Description:
[src/sys/dev/pci/if_et.c:2055] -> [src/sys/dev/pci/if_et.c:2056]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.


Source code is


    if (error) {
        if (!error) {
            bus_dmamap_unload(sc->sc_dmat, sc->sc_mbuf_tmp_dmap);
            error = EFBIG;
            aprint_error_dev(sc->sc_dev, "too many segments?!\n");
        }


>How-To-Repeat:

>Fix: