kern/50818: src/sys/dev/pci/if_alc.c:2391: contradictory nested if ?

[dcb314%hotmail.com@localhost]

>Number:         50818
>Category:       kern
>Synopsis:       src/sys/dev/pci/if_alc.c:2391: contradictory nested if ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 17 11:00:01 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160216
>Organization:
>Environment:
>Description:
[src/sys/dev/pci/if_alc.c:2391] -> [src/sys/dev/pci/if_alc.c:2392]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.

Source code is


    if (error != 0) {
        if (!error) {
            bus_dmamap_unload(sc->sc_dmat,
                sc->alc_cdata.alc_rx_sparemap);
            error = EFBIG;
            printf("%s: too many segments?!\n",
                device_xname(sc->sc_dev));
        }

>How-To-Repeat:

>Fix: