kern/50820: src/sys/dev/pci/pccbb.c:2769 contradictory nested if ?

[dcb314%hotmail.com@localhost]

>Number:         50820
>Category:       kern
>Synopsis:       src/sys/dev/pci/pccbb.c:2769 contradictory nested if ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 17 11:05:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160216
>Organization:
>Environment:
>Description:
[src/sys/dev/pci/pccbb.c:2769] -> [src/sys/dev/pci/pccbb.c:2771]: (warning) Opposite conditions in nested 'if' blocks lead to a dead code block.

Source code is


   if (!(pf->cfe->flags & PCMCIA_CFE_IRQLEVEL)) {
        /* what should I do? */
        if ((pf->cfe->flags & PCMCIA_CFE_IRQLEVEL)) {
            DPRINTF(("%s does not provide edge nor pulse "
                "interrupt\n", device_xname(sc->sc_dev)));
            return NULL;
        }



>How-To-Repeat:

>Fix: