NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: misc/50166



El 18/09/15 a les 14:57, Antti Kantee ha escrit:
On Fri, Sep 11, 2015 at 01:04:08AM +0200, Robert Millan wrote:
I just realized there's a much simpler way around this, if we want to test for
MAXPATHLEN as you suggest, autoconf really isn't necessary as it can be done
directly in C pre-processor.

See attached patch, please let me know what you think.

Even if make is the only thing in tools currently using MAXPATHLEN,
could we put the compat value into tools/compat/compat_defs.h
instead?

Apart from that, the approach seems ok.

compat_defs.h doesn't seem to help as make.h does:

/home/amnesia/rump/debian/rumpkernel/buildrump.sh/src/tools/make/../../usr.bin/make/arch.c: In function 'ArchSVR4Entry':
/home/amnesia/rump/debian/rumpkernel/buildrump.sh/src/tools/make/../../usr.bin/make/arch.c:815:47: error: 'MAXPATHLEN' undeclared (first use in this function)
     (void)strncpy(name, &ar->fnametab[entry], MAXPATHLEN);

what is the expected include path for arch.c -> compat_defs.h?

--
--
Robert Millan



Home | Main Index | Thread Index | Old Index