Re: misc/50166

[Robert Millan <rmh%gnu.org@localhost>]

The following reply was made to PR misc/50166; it has been noted by GNATS.

From: Robert Millan <rmh%gnu.org@localhost>
To: Antti Kantee <pooka%NetBSD.org@localhost>, Robert Millan <rmh%gnu.org@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, misc-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: misc/50166
Date: Fri, 18 Sep 2015 22:25:23 +0200

 El 18/09/15 a les 14:57, Antti Kantee ha escrit:
 > On Fri, Sep 11, 2015 at 01:04:08AM +0200, Robert Millan wrote:
 >> I just realized there's a much simpler way around this, if we want to test for
 >> MAXPATHLEN as you suggest, autoconf really isn't necessary as it can be done
 >> directly in C pre-processor.
 >>
 >> See attached patch, please let me know what you think.
 >
 > Even if make is the only thing in tools currently using MAXPATHLEN,
 > could we put the compat value into tools/compat/compat_defs.h
 > instead?
 >
 > Apart from that, the approach seems ok.
 
 compat_defs.h doesn't seem to help as make.h does:
 
 /home/amnesia/rump/debian/rumpkernel/buildrump.sh/src/tools/make/../../usr.bin/make/arch.c: In function 'ArchSVR4Entry':
 /home/amnesia/rump/debian/rumpkernel/buildrump.sh/src/tools/make/../../usr.bin/make/arch.c:815:47: error: 'MAXPATHLEN' undeclared (first use in this function)
       (void)strncpy(name, &ar->fnametab[entry], MAXPATHLEN);
 
 what is the expected include path for arch.c -> compat_defs.h?
 
 -- 
 -- 
 Robert Millan