NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: misc/50166



On Fri, Sep 11, 2015 at 01:04:08AM +0200, Robert Millan wrote:
> I just realized there's a much simpler way around this, if we want to test for
> MAXPATHLEN as you suggest, autoconf really isn't necessary as it can be done
> directly in C pre-processor.
> 
> See attached patch, please let me know what you think.

Even if make is the only thing in tools currently using MAXPATHLEN,
could we put the compat value into tools/compat/compat_defs.h
instead?

Apart from that, the approach seems ok.

> Index: rumpkernel-0~20150715/buildrump.sh/src/usr.bin/make/make.h
> ===================================================================
> --- rumpkernel-0~20150715.orig/buildrump.sh/src/usr.bin/make/make.h	2015-07-23 22:54:05.000000000 +0200
> +++ rumpkernel-0~20150715/buildrump.sh/src/usr.bin/make/make.h	2015-09-05 12:31:02.556270631 +0200
> @@ -503,4 +503,11 @@
>  #define MAX(a, b) ((a > b) ? a : b)
>  #endif
>  
> +/* GNU/Hurd systems lack MAXPATHLEN */
> +#include <limits.h>
> +#ifndef MAXPATHLEN
> +#warning "MAXPATHLEN undefined on this system, forcing an arbitrary limit"
> +#define MAXPATHLEN	4096
> +#endif
> +
>  #endif /* _MAKE_H_ */



Home | Main Index | Thread Index | Old Index