kern/46973: kauth_authorize_action_internal() returns non-macro value as it should do

[Wolfgang.Stukenbrock%nagler-company.com@localhost]

>Number:         46973
>Category:       kern
>Synopsis:       kauth_authorize_action_internal() returns non-macro value as 
>it should do
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Sep 16 13:55:00 +0000 2012
>Originator:     Dr. Wolfgang Stukenbrock
>Release:        NetBSD current (perhaps 6.x too)
>Organization:
Dr. Nagler & Company GmbH
>Environment:
        
        
System: NetBSD s012 4.0 NetBSD 4.0 (NSW-S012) #12: Tue Jun 19 11:15:19 CEST 
2012 ncadmin@s012:/usr/src/sys/arch/amd64/compile/NSW-S012 amd64
Architecture: x86_64
Machine: amd64
>Description:
        The function kauth_authorize_action_internal() now returns yes/no/defer 
status to caller.
        When splitting the function kauth_authorize_action() into peaces, one 
old check
        for kernel internal calls is moved to kauth_authorize_action_internal() 
but has not been
        corrected to return one of the KAUTH_RESULT_xxx macros.
        It still return the number 0 that was SUCCESS in the past.
>How-To-Repeat:
        found by a look into the sources
>Fix:
        Return the correct value (KAUTH_RESULT_DENY, KAUTH_RESULT_ALLOW or 
KAUTH_RESULT_DEFER) instead of 0.
        I do not know the correct value, because I'm not completly confirm with 
the "new" auth-check semantics
        in -current where the order of checks has changed (sometimes) ...

>Unformatted: